Skip to content
This repository was archived by the owner on Mar 28, 2023. It is now read-only.

[SYCL] Fix missing Unix tools on Windows #383

Closed

Conversation

alexbatashev
Copy link

Use echo instead of true and check for other tools availability

Use `echo` instead of `true` and check for other tools availability
@bader
Copy link

bader commented Jul 29, 2021

Why these tests use Linux tool in the first place? Can't we write tests using just LLVM tools?

@steffenlarsen
Copy link

I ran the tests on Windows and most tests now pass. The failing tests fall into two errors, which I suspect are related:

  • Regression/pi_release.cpp
  • InorderQueue/in_order_property_trace.cpp
  • Basic/event_release.cpp
  • Scheduler/InOrderQueueDeps.cpp
  • Basic/use_pinned_host_memory.cpp
  • Basic/queue/release.cpp
  • Scheduler/ReleaseResourcesTest.cpp
  • Tracing/pi_tracing_test.cpp
  • Scheduler/MemObjRemapping.cpp
  • Basic/info_ocl_version.cpp
  • Tracing/buffer_printers.cpp

Fail with:

...
$ "env" "SYCL_PI_TRACE=-1" "echo" "C:\Path\to\tests\Output\test_name.cpp.tmp.out"
# command stderr:
Error: 'env' cannot call 'echo'
error: command failed with exit status: 127
  • Basic/buffer/native_buffer_creation_flags.cpp

Fail with:

...
$ ":" "RUN: at line 2"
$ "echo" "SYCL_PI_TRACE=-1" "C:\Path\to\tests\Output\test_name.cpp.tmp.out"
# command stderr:
stdin and stderr redirects not supported for echo
error: command failed with exit status: 127

@vladimirlaz
Copy link

@alexbatashev have you tried to use LIT shell? It can be set using line like:

./llvm-spirv/test/lit.cfg.py:config.test_format = lit.formats.ShTest(not llvm_config.use_lit_shell)

@bader
Copy link

bader commented Sep 14, 2021

@alexbatashev, please, resolve merge conflicts.

Copy link

@kbobrovs kbobrovs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SpecConstants/1.2.1 LGTM

@bader
Copy link

bader commented Sep 21, 2021

@alexbatashev, please, resolve merge conflicts.

@alexbatashev, ping.

@alexbatashev
Copy link
Author

Decided to split in parts to make it more manageable
Part 1: #475

myler pushed a commit to myler/llvm-test-suite that referenced this pull request Apr 12, 2022
…ntel#383)

This patch also repleaces some obsolete APIs such as esimd_get_value()
or flat_atomic()

Signed-off-by: Vyacheslav N Klochkov <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants