This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[SYCL] Fix scan tests for multiplication #404
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Michoumichmich
requested review from
AlexeySachkov and
Pennycook
as code owners
Michoumichmich
requested review from
bader,
romanovvlad and
vladimirlaz
as code owners
|
Maybe we should consider starting all test vectors at 2 which would avoid conflicts with identities. As an example, right now if an implementation uses 0 as the identity for |
AlexeySachkov
approved these changes
Aug 18, 2021
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
Co-authored-by: Michel Migdal <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The testing vector starts with a 0 which means that testing inclusive and exclusive scans with
sycl::multiplieswill always return a vector of zeros . This is why the bug intel/llvm#4337 went unnoticed (as it used 0 for multiplication identity which made the scan always return a vector of 0).This commit adds a testing over a small vector of size 12 which starts at 1. Computing the inclusive scan with
sycl::multipliesshould give a vector of factorials and not overflow theint.Signed-off-by: Michel Migdal [email protected]