Skip to content
This repository was archived by the owner on Mar 28, 2023. It is now read-only.

[SYCL] Add tests for SYCL2020 queue::parallel_for() shortcuts #405

Merged
merged 4 commits into from
May 3, 2022
Merged

[SYCL] Add tests for SYCL2020 queue::parallel_for() shortcuts #405

merged 4 commits into from
May 3, 2022

Conversation

v-klochkov
Copy link

Signed-off-by: Vyacheslav N Klochkov [email protected]

@v-klochkov v-klochkov force-pushed the reduction_queue_parallel_for branch from 7ca5272 to 835a263 Compare April 22, 2022 04:10
@v-klochkov
Copy link
Author

/verify with intel/llvm#4352

@v-klochkov v-klochkov marked this pull request as ready for review April 22, 2022 04:19
@v-klochkov v-klochkov requested a review from a team as a code owner April 22, 2022 04:19
@v-klochkov
Copy link
Author

@smaslov-intel - all tests passed. Please review this PR.
It splits the test 'reduction_queue_parallel_for.cpp' into 2 tests - 1 with nd_range, 1 with - range.
It also adds a new test that checks 2 reductions in 1 parallel_for.

@v-klochkov v-klochkov force-pushed the reduction_queue_parallel_for branch from 80b5ab8 to 84a92b2 Compare May 3, 2022 14:59
@v-klochkov v-klochkov force-pushed the reduction_queue_parallel_for branch from 84a92b2 to 37077d2 Compare May 3, 2022 15:25
@v-klochkov v-klochkov requested a review from steffenlarsen May 3, 2022 15:25
steffenlarsen
steffenlarsen reviewed May 3, 2022
View reviewed changes
SYCL/Reduction/reduction_nd_N_queue_shortcut.cpp
// RUN: %CPU_RUN_PLACEHOLDER %t.out

// `Group algorithms are not supported on host device.` on NVidia.
// XFAIL: hip_nvidia
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if this is still applicable. Should we rerun the tests?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think normal CI would report/complain on this test if it passed on nvidia, right?

Copy link
Author

@v-klochkov v-klochkov May 3, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean, this test copies that from the existing test (being removed/replaced in this PR): SYCL/Reduction/reduction_queue_parallel_for.cpp . If it passed, it would be seen during CI runs.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it is the case for other similar tests, then I suspect you are right. If it starts unexpectedly passing we'll know to remove it. 😄

@v-klochkov v-klochkov merged commit 89d93f3 into intel:intel May 3, 2022
@v-klochkov v-klochkov deleted the reduction_queue_parallel_for branch May 3, 2022 22:04
myler pushed a commit to myler/llvm-test-suite that referenced this pull request Jun 17, 2022
@v-klochkov @bb-sycl
[SYCL] Add tests for SYCL2020 queue::parallel_for() shortcuts (intel#405
c3e49c9 
)

* [SYCL] Add tests for SYCL2020 queue::parallel_for() shortcuts using reductions

Signed-off-by: Vyacheslav N Klochkov <[email protected]>
aelovikov-intel pushed a commit to aelovikov-intel/llvm that referenced this pull request Mar 27, 2023
@v-klochkov
[SYCL] Add tests for SYCL2020 queue::parallel_for() shortcuts (intel/…
57f4076 
…llvm-test-suite#405)

* [SYCL] Add tests for SYCL2020 queue::parallel_for() shortcuts using reductions

Signed-off-by: Vyacheslav N Klochkov <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@smaslov-intel smaslov-intel smaslov-intel approved these changes

@steffenlarsen steffenlarsen steffenlarsen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@v-klochkov @smaslov-intel @steffenlarsen