Skip to content
This repository was archived by the owner on Mar 28, 2023. It is now read-only.

[SYCL] Added test for deprecated features #435

Merged
merged 9 commits into from
Sep 6, 2021

Conversation

maximdimakov
Copy link

@maximdimakov maximdimakov commented Sep 1, 2021

The test is created for the check that ABI of deprecated API is not broken after this API was removed. Removed API was wrapped in __SYCL_INTERNAL_API macro. Also this test checks that removed API is working with this macro.
Signed-off-by: mdimakov [email protected]

Copy link

@vladimirlaz vladimirlaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you provide more details for the purpose of the test?
It is unclear what is actually tested especially because there is no check condition step.

@vladimirlaz
Copy link

if a new directory is added please update .github/CODEOWNERS.

@maximdimakov
Copy link
Author

@vladimirlaz I updated the description of PR.

Co-authored-by: Alexander Batashev <[email protected]>
@romanovvlad romanovvlad merged commit 4aee113 into intel:intel Sep 6, 2021
alexbatashev added a commit to alexbatashev/llvm-test-suite that referenced this pull request Sep 11, 2021
* upstream/intel: (70 commits)
  [SYCL][Matrix] Add the 8 bit type variants (intel#443)
  [SYCL] testing of linking in the presence of multiple kernels (intel#440)
  [NFC] Add Sergey to CODEOWNERS of USM test (intel#455)
  [ESIMD] E2E test for writeable simd_view subscript operator (intel#415)
  [SYCL] Eliminate usages of _class aliases (intel#449)
  [SYCL] Enable assert AOT test (intel#450)
  [SYCL] Disable flaky Plugin/level_zero_dynamic_batch_test (intel#453)
  [SYCL] Ensure JIT failure on all Intel devices (intel#452)
  [SYCL] Removed the remained handler::codeplay_host_task (intel#451)
  [SYCL] Test for Group Mask feature (intel#441)
  [SYCL] Update kernel_bundle test for default contexts (intel#446)
  [SYCL] Replace using of ONEAPI/INTEL namespaces with ext::oneapi/intel (intel#442)
  [SYCL] Replace deprecated has_extension (intel#434)
  [SYCL] test for intel/llvm#4405 (intel#424)
  [SYCL] Remove function pointers extension tests (intel#437)
  [SYCL] Added test for deprecated features (intel#435)
  Fix check for availability of sycl.hpp (intel#445)
  [SYCL] Update tests for default context extension (intel#433)
  Use sycl.hpp workaround only if compiler doesn't have it (intel#439)
  [SYCL] Allow extra command line options implicitely added by compiler (intel#432)
  ...
aelovikov-intel pushed a commit to aelovikov-intel/llvm that referenced this pull request Mar 27, 2023
The test is created for the check that ABI of deprecated API is not
broken after this API was removed. Removed API was wrapped in
__SYCL_INTERNAL_API macro. Also this test checks that removed
API is working with this macro.

Signed-off-by: mdimakov <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants