This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[ESIMD] Allow constructing simd_view from simd #454
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@v-klochkov, could you please finish this PR as well. |
kbobrovs
reviewed
Nov 2, 2021
| // construct complete view of a vector. | ||
| passed &= test(q, "constructor from simd", | ||
| [](auto &va_view, auto &vb_view) SYCL_ESIMD_FUNCTION { | ||
| simd<int, 4> vb = vb_view; |
There was a problem hiding this comment.
I added the test case for VL=1 to all tests in this LIT: 0d2eb25.
During adding that I discovered that 'simd v = other_simd.select<4,1>(0)' does not work and that may be pretty inconvenient. That is also added here: intel/llvm#4892
Signed-off-by: Vyacheslav N Klochkov <[email protected]>
v-klochkov
reviewed
Nov 4, 2021
|
The only failed test in CI is invalid_event.cpp, which has been disabled for opencl+acc here: #652 |
kbobrovs
previously approved these changes
Dec 22, 2021
| va_view_copy = vb_view_copy; | ||
| }); | ||
| passed &= tests(q, "copy constructor", | ||
| [](auto &va_view, auto &vb_view) SYCL_ESIMD_FUNCTION { |
There was a problem hiding this comment.
it is really hard to guess what this 'auto' means. Can concrete simd_view type be specified?
|
@vladimirlaz - would you please merge this PR. |
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
…#454) Signed-off-by: Vyacheslav N Klochkov <[email protected]> Co-authored-by: Vyacheslav N Klochkov <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.