This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[SYCL] add host-task-dependency test #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexander Flegontov <[email protected]>
vladimirlaz
reviewed
Nov 2, 2020
| @@ -2,6 +2,9 @@ if( NOT OpenCL_LIBRARY ) | |||
| find_package(OpenCL) | |||
| endif() | |||
|
|
|||
| find_package(Threads REQUIRED) | |||
| set(SYCL_THREADS_LIB ${CMAKE_THREAD_LIBS_INIT}) | |||
There was a problem hiding this comment.
You should also propagate the value in lit.cfg.py and lit.site.cfg.cpy.in.
Please verify your change before submition
There was a problem hiding this comment.
The value is already there. I checked it again.
https://github.com/intel/llvm-test-suite/blob/intel/SYCL/lit.cfg.py#L113
https://github.com/intel/llvm-test-suite/blob/intel/SYCL/lit.site.cfg.py.in#L25
So only changes in SYCL/CMakeLists.txt are needed for SYCL_THREADS_LIB to work with threads.
|
@vladimirlaz ping |
vladimirlaz
approved these changes
Nov 2, 2020
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
Signed-off-by: Alexander Flegontov <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alexander Flegontov [email protected]