This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[SYCL] Add E2E tests for device code instrumentation #484
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 28, 2021 14:15
Add a couple tests with execute-only kernels to ensure that ITT annotations' generation doesn't break the compilation/execution. This aims to test intel/llvm#4615. Signed-off-by: Artem Gindinson <[email protected]>
Signed-off-by: Artem Gindinson <[email protected]>
AGindinson
requested review from
bader,
romanovvlad,
vladimirlaz and
vzakhari
as code owners
|
The tests are non-breaking even w/o the product changes, so committing them and re-running Precommit for intel/llvm#4615 is a possibility. EDIT: Actually, the test changes are breaking, as the product changes include the fix for the required CLI option... |
vladimirlaz
previously approved these changes
Sep 28, 2021
MrSidims
previously approved these changes
Sep 28, 2021
Signed-off-by: Artem Gindinson <[email protected]>
AGindinson
dismissed stale reviews from MrSidims and vladimirlaz
via
8f9c61d
Signed-off-by: Artem Gindinson <[email protected]>
vzakhari
reviewed
Sep 28, 2021
Signed-off-by: Artem Gindinson <[email protected]>
AlexeySachkov
pushed a commit
to intel/llvm
that referenced
this pull request
Sep 29, 2021
- Fix the malfunctioning driver option for passing `-fsycl-instrument-device-code` to CC1 for SPIR-V-based targets. - Add the ITT device libraries when the CLI option is enabled, excluding these from `-fno-sycl-device-lib` effects. - Disable ITT annotations for ESIMD code. Tests are in intel/llvm-test-suite#484. Signed-off-by: Artem Gindinson <[email protected]>
|
@vzakhari @vladimirlaz The CI has finally picked the correct nightly build of the compiler, so the patch should be good for the final review. |
vladimirlaz
previously approved these changes
Oct 1, 2021
vladimirlaz
reviewed
Oct 4, 2021
Signed-off-by: Artem Gindinson <[email protected]>
|
the fix for the failure is under #494 |
vladimirlaz
approved these changes
Oct 4, 2021
vzakhari
approved these changes
Oct 4, 2021
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
…-suite#484) Signed-off-by: Artem Gindinson <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a couple tests with execute-only kernels to ensure that ITT
annotations' generation doesn't break the compilation/execution.
This aims to test intel/llvm#4615.
Signed-off-by: Artem Gindinson [email protected]