This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[SYCL][HIP] Marked failing tests as xfail or unsupported on hip_nvidia. #512
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests that already failed for cuda/hip_amd and also fail on hip_nvidia have been marked as UNSUPPORTED or XFAIL.
XFAILS on both hip_amd and hip_nvidia:
Basic/device_event.cpp
Basic/kernel_info.cpp
Reduction/reduction_big_data.cpp
Reduction/reduction_nd_conditional.cpp
Reduction/reduction_nd_ext_double.cpp
Reduction/reduction_nd_ext_half.cpp
Reduction/reduction_nd_lambda.cpp
Reduction/reduction_nd_s0_dw.cpp
Reduction/reduction_nd_s0_rw.cpp
Reduction/reduction_nd_s1_dw.cpp
Reduction/reduction_nd_s1_rw.cpp
Reduction/reduction_placeholder.cpp
Reduction/reduction_queue_parallel_for.cpp
Reduction/reduction_usm.cpp
Reduction/reduction_usm_dw.cpp
SubGroup/sub_group_as.cpp
SubGroup/sub_group_as_vec.cpp
SubGroup/sub_groups_sycl2020.cpp
UNSUPPORTED hip_amd and hip_nvidia:
DeprecatedFeatures/parallel_for_range.cpp
UNSUPPORTED cuda and hip_nvidia:
Basic/host-task-dependency.cpp
ESIMD/api/simd_negation_operator.cpp
ESIMD/api/simd_view_copy_move_assign.cpp
ESIMD/api/simd_view_negation_operator.cpp
ESIMD/api/slm_gather_scatter.cpp
ESIMD/api/slm_gather_scatter_rgba.cpp
ESIMD/regression/replicate_bug.cpp
ESIMD/usm_gather_scatter_rgba.cpp
InlineAsm/Negative/asm_bad_opcode.cpp
InlineAsm/Negative/asm_bad_operand_syntax.cpp
InlineAsm/Negative/asm_duplicate_label.cpp
InlineAsm/Negative/asm_illegal_exec_size.cpp
InlineAsm/Negative/asm_missing_label.cpp
InlineAsm/Negative/asm_missing_region.cpp
InlineAsm/Negative/asm_simple.cpp
InlineAsm/Negative/asm_undefined_decl.cpp
InlineAsm/Negative/asm_undefined_pred.cpp
InlineAsm/Negative/asm_wrong_declare.cpp
InlineAsm/asm_16_empty.cpp
InlineAsm/asm_16_matrix_mult.cpp
InlineAsm/asm_16_no_input_int.cpp
InlineAsm/asm_16_no_opts.cpp
InlineAsm/asm_8_empty.cpp
InlineAsm/asm_8_no_input_int.cpp
InlineAsm/asm_arbitrary_ops_order.cpp
InlineAsm/asm_decl_in_scope.cpp
InlineAsm/asm_float_add.cpp
InlineAsm/asm_float_imm_arg.cpp
InlineAsm/asm_float_neg.cpp
InlineAsm/asm_if.cpp
InlineAsm/asm_imm_arg.cpp
InlineAsm/asm_loop.cpp
InlineAsm/asm_mul.cpp
InlineAsm/asm_no_output.cpp
InlineAsm/asm_plus_mod.cpp
InlineAsm/asm_switch.cpp
Plugin/enqueue-arg-order-buffer.cpp
Notes for future work:
Sometimes it appears that tests are failing on hip_nvidia for different reasons that the test is failing on hip_amd.
Error messages etc for hip_nvidia are noted in the test header in such cases.
There are cases that are failing on hip_nvidia that did not fail on hip_amd or cuda and require further investigation:
Basic/diagnostics/handler.cpp
Basic/memory-consumption.cpp
Basic/partition_supported.cpp
Basic/queue/queue.cpp
Basic/queue/release.cpp
Basic/stream/auto_flush.cpp
DeprecatedFeatures/kernel_info.cpp
DeprecatedFeatures/queue_old_interop.cpp
InorderQueue/in_order_property_trace.cpp
Plugin/sycl-ls-gpu-hip.cpp
Reduction/reduction_reducer_op_eq.cpp
Regression/context_is_destroyed_after_exception.cpp
Scheduler/InOrderQueueDeps.cpp
Scheduler/MemObjRemapping.cpp
Scheduler/MultipleDevices.cpp
Scheduler/ReleaseResourcesTest.cpp
SubGroup/sub_group_as.cpp
SubGroup/sub_group_as_vec.cpp
Tracing/buffer_printers.cpp
Tracing/pi_tracing_test.cpp
Eight tests are unexpectedly passing on hip_nvidia.
Unexpectedly Passed Tests (8):
SYCL :: Basic/aspects.cpp
SYCL :: Basic/buffer/buffer_full_copy.cpp
SYCL :: Basic/span.cpp
SYCL :: DeprecatedFeatures/get-options.cpp
SYCL :: DeprecatedFeatures/kernel-and-program.cpp
SYCL :: Regression/same_unnamed_kernels.cpp
SYCL :: Sampler/normalized-clampedge-linear-float.cpp
SYCL :: Scheduler/CommandCleanupThreadSafety.cpp
Signed-off-by: JackAKirk [email protected]