[ESIMD] Add ahead-of-time compilation test. #523
Conversation
Signed-off-by: Konstantin S Bobrovsky <[email protected]>
|
|
||
| using namespace cl::sycl; | ||
|
|
||
| #ifndef ENABLE_SIMD |
There was a problem hiding this comment.
It is unclear here, why this macro is needed? It is just turned on in the next line all the time because it is not set in the compilation line. Is it supposed to be disabled some time later? It may be good to have a TODO comment here.
There was a problem hiding this comment.
ENABLE_SIMD/ENABLE_SYCL are used to enable/disable corresponding parts in the test. e.g. -DENABLE_SYCL=0 disables the SYCL part, which is used in one of the RUN: commands above.
There was a problem hiding this comment.
I see how ENABLE_SYCL is either set to 0 or unset in the command line, but ENABLE_SIMD is not used in the command line right now, so it is always set to 1 in the line 34, right?
There was a problem hiding this comment.
Right. ENABLE_SIMD is just for convenience for somebody who would want to try.
Signed-off-by: Konstantin S Bobrovsky <[email protected]>
Signed-off-by: Konstantin S Bobrovsky [email protected]