Skip to content
This repository was archived by the owner on Mar 28, 2023. It is now read-only.

[SYCL] Test indirect access memory tracking in the L0 plugin #532

Merged
merged 3 commits into from
Mar 1, 2022

Conversation

againull
Copy link

No description provided.

@againull againull requested a review from rdeodhar October 22, 2021 20:59
@rdeodhar
Copy link

To improve readability I suggest

  1. writing the accessors as: "accessor acc { b_d3_data, cgh, read_write };"
  2. removing "cl::sycl::" throughout since you already have "using namespace sycl;"

But, what is the test checking exactly? Is indirect access tracking on by default?

@againull
Copy link
Author

To improve readability I suggest

  1. writing the accessors as: "accessor acc { b_d3_data, cgh, read_write };"
  2. removing "cl::sycl::" throughout since you already have "using namespace sycl;"

But, what is the test checking exactly? Is indirect access tracking on by default?

Addressed comments and added description of the test.

@againull againull requested a review from a team as a code owner January 27, 2022 02:40
@rdeodhar
Copy link

I ran the test on Gen9 with/without the env var on a recent build of intel/llvm.
Once, with the env var I got this error:
$ SYCL_PI_LEVEL_ZERO_TRACK_INDIRECT_ACCESS_MEMORY=1 ./a.out
pass
double free or corruption (out)

There may still be a bug in the implementation, but I'm approving this PR for the test.

@againull
Copy link
Author

againull commented Jan 27, 2022

I ran the test on Gen9 with/without the env var on a recent build of intel/llvm. Once, with the env var I got this error: $ SYCL_PI_LEVEL_ZERO_TRACK_INDIRECT_ACCESS_MEMORY=1 ./a.out pass double free or corruption (out)

There may still be a bug in the implementation, but I'm approving this PR for the test.

@rdeodhar I can't reproduce this error with several thousand runs. Did you change the test or compiler somehow?

@rdeodhar
Copy link

I didn't change the test.
I ran it with an intel/llvm compiler as in PR 4891, which has just been merged. So effectively, with the latest intel/llvm compiler.

@againull
Copy link
Author

againull commented Jan 27, 2022

I didn't change the test. I ran it with an intel/llvm compiler as in PR 4891, which has just been merged. So effectively, with the latest intel/llvm compiler.

Still can't reproduce neither with build from PR 4891 nor the latest intel/llvm or nightly build.
Could you please create a tracker with detailed instructions.

@vladimirlaz
Copy link

is this PR still needed? Should it be merged?

@againull
Copy link
Author

againull commented Mar 1, 2022

is this PR still needed? Should it be merged?

It was waiting for gpu runtime version to be uplifted because old driver had an issue. GPU driver version was uplifted 4 days ago, so this can be merged now.

@againull againull merged commit ad27262 into intel:intel Mar 1, 2022
myler pushed a commit to myler/llvm-test-suite that referenced this pull request Apr 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants