This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[SYCL] Remove unnecessary llvm-spirv substitution #540
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove a tool substitution which effectively assumes that llvm-spirv is in sycl_tools_dir. If it's not, the substitution results in an incorrect absolute path, preventing llvm-spirv from being found elsewhere via PATH. If llvm-spirv is in sycl_tools_dir the removed substitution unnecessary because we also add sycl_tools_dir to PATH.
tcreech-intel
requested review from
bader,
romanovvlad and
vladimirlaz
as code owners
|
@vladimirlaz, would it be possible for you to take a look at this? |
vladimirlaz
approved these changes
Nov 8, 2021
myler
pushed a commit
to myler/llvm-test-suite
that referenced
this pull request
Apr 12, 2022
Note: this is a cherry-pick of intel-llvm/llvm-test-suite intel#540. Remove a tool substitution which effectively assumes that llvm-spirv is in sycl_tools_dir. If it's not, the substitution results in an incorrect absolute path, preventing llvm-spirv from being found elsewhere via PATH. If llvm-spirv is in sycl_tools_dir the removed substitution unnecessary because we also add sycl_tools_dir to PATH.
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
…ite#540) Remove a tool substitution which effectively assumes that llvm-spirv is in sycl_tools_dir. If it's not, the substitution results in an incorrect absolute path, preventing llvm-spirv from being found elsewhere via PATH. If llvm-spirv is in sycl_tools_dir the removed substitution unnecessary because we also add sycl_tools_dir to PATH.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes a tool substitution which effectively assumes that llvm-spirv is
in sycl_tools_dir. If it's not, the substitution results in an incorrect
absolute path, preventing llvm-spirv from being found elsewhere via
PATH. If llvm-spirv is in sycl_tools_dir the removed substitution is
unnecessary because we also add sycl_tools_dir to PATH.