This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[ESIMD] Fix several non-critical errors/warnings in LIT tests #546
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v-klochkov
force-pushed
the
esimd_non_critical_fixes
branch
2 times, most recently
from
243a767 to
a628a45
Compare
1. Added sycl::free() where needed 2. Replaced exception::get_cl_code() to avoid warnings. In about half of places the call was used incorrectly (returned non-zero value instead of zero/false); 3. Removed usages of "cl::" prefix; 4. Replaced some other deprecated APIs. Signed-off-by: Vyacheslav N Klochkov <[email protected]>
v-klochkov
force-pushed
the
esimd_non_critical_fixes
branch
from
a628a45 to
e85d45d
Compare
kbobrovs
reviewed
Nov 3, 2021
kbobrovs
reviewed
Nov 3, 2021
Co-authored-by: kbobrovs <[email protected]>
kbobrovs
approved these changes
Nov 3, 2021
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
…llvm-test-suite#546) * [ESIMD] Fix several non-critical errors/warnings in LIT tests 1. Added sycl::free() where needed 2. Replaced exception::get_cl_code() to avoid warnings. In about half of places the call was used incorrectly (returned non-zero value instead of zero/false); 3. Removed usages of "cl::" prefix; 4. Replaced some other deprecated APIs. Signed-off-by: Vyacheslav N Klochkov <[email protected]> Co-authored-by: kbobrovs <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
places the call was used incorrectly (returned non-zero value instead
of zero/false);
Signed-off-by: Vyacheslav N Klochkov [email protected]