This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[SYCL] Add more tests for experimental::printf #569
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
December 9, 2021 18:23
Signed-off-by: Artem Gindinson <[email protected]>
Signed-off-by: Artem Gindinson <[email protected]>
Signed-off-by: Artem Gindinson <[email protected]>
Signed-off-by: Artem Gindinson <[email protected]>
Signed-off-by: Artem Gindinson <[email protected]>
Signed-off-by: Artem Gindinson <[email protected]>
Aims to test intel/llvm#5069. Signed-off-by: Artem Gindinson <[email protected]>
Signed-off-by: Artem Gindinson <[email protected]>
AGindinson
reviewed
Dec 13, 2021
added 3 commits
December 13, 2021 16:50
Signed-off-by: Artem Gindinson <[email protected]>
Signed-off-by: Artem Gindinson <[email protected]>
Signed-off-by: Artem Gindinson <[email protected]>
|
/verify with intel/llvm#5069 |
AGindinson
requested review from
bader,
romanovvlad and
vladimirlaz
as code owners
|
The Linux/Windows CI failures in |
|
I suggest we update CODEOWNERS for those new files as well |
added 3 commits
December 16, 2021 21:55
Signed-off-by: Artem Gindinson <[email protected]>
Signed-off-by: Artem Gindinson <[email protected]>
|
/verify with intel/llvm#5069 |
|
Together with the product PR, the unrelated DeviceLib failure on Windows is the only one. |
AlexeySachkov
pushed a commit
to intel/llvm
that referenced
this pull request
Dec 22, 2021
Allow generic address space strings into `experimental::printf` and, consequently, into `__spirv_ocl_printf` declarations. To mitigate the lack of device BE support for generic address space literals, we implement a pass to move the literal argument into constant address space whenever possible. This is a temporary solution; long-term, we should replace this with proper support of generic address-spaced format strings at the level of SPIR-V translation and device backends. Tested in intel/llvm-test-suite#569. Signed-off-by: Artem Gindinson <[email protected]>
|
/verify with intel/llvm#5069 |
AlexeySachkov
commented
Dec 22, 2021
There was a problem hiding this comment.
I can't approve because I'm the initial author of the PR, but changes introduced later by @AGindinson looks good to me.
AGindinson
pushed a commit
to AGindinson/llvm-test-suite
that referenced
this pull request
Dec 23, 2021
As shown by CI for intel#569, the unsupported combination of opencl && acc still shows up. Attempt to fix this by using a common operator style as a follow-up to intel#652. Signed-off-by: Artem Gindinson <[email protected]>
bader
pushed a commit
that referenced
this pull request
Dec 23, 2021
As shown by CI for #569, the unsupported combination of opencl && acc still shows up. Attempt to fix this by using a common operator style as a follow-up to #652. Signed-off-by: Artem Gindinson <[email protected]>
added 4 commits
December 27, 2021 10:54
Signed-off-by: Artem Gindinson <[email protected]>
Signed-off-by: Artem Gindinson <[email protected]>
Signed-off-by: Artem Gindinson <[email protected]>
|
@AlexeySachkov, could you please revise the latest changes? |
|
@intel/llvm-gatekeepers Could you please consider merging this based on the DPC++ tools member approval? |
|
@AGindinson, @AlexeySachkov it looks like the new tests are failing on HIP in pre-commit: https://github.com/intel/llvm/runs/4643766953?check_suite_focus=true Please fix it ASAP |
|
@vladimirlaz, #685 should do the trick. Thanks! |
myler
added a commit
to myler/llvm-test-suite
that referenced
this pull request
Apr 12, 2022
Auto pulldown and update tc files for xmain-cand branch on 20220118
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
…#569) Signed-off-by: Artem Gindinson <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.