This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[SYCL][HIP] Remove xfail from fails due to wrong event_t address space #570
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t4c1
requested review from
bader,
romanovvlad,
vladimirlaz and
a team
as code owners
vladimirlaz
approved these changes
Nov 16, 2021
t4c1
changed the title
bader
changed the title
bader
pushed a commit
to intel/llvm
that referenced
this pull request
Jan 11, 2022
Fixes wrong address spaces for `event_t`. It should be private, but in SYCL it was defaulting to generic. On the other hand in libclc pointer to `event_t` was private, while it should be generic. (We don't see similar issues on NVPTX, as there private address space is in fact implemented as generic in IR). Change to test suite: intel/llvm-test-suite#570
bader
added a commit
that referenced
this pull request
Jan 11, 2022
…t_t address spaces (#570)" (#724) This reverts commit 367e10e. Reverting due to intel/llvm#4966 revert.
bader
pushed a commit
that referenced
this pull request
Jan 13, 2022
…ong event_t address spaces (#570)" (#724)" (#732) This reverts commit 0b6fc11. The failing test is fixed by intel/llvm#5293.
myler
pushed a commit
to myler/llvm-test-suite
that referenced
this pull request
Apr 12, 2022
…ess spaces (intel#570) Remove xfail from tests fixed by: intel/llvm#4966
myler
pushed a commit
to myler/llvm-test-suite
that referenced
this pull request
Apr 12, 2022
…t_t address spaces (intel#570)" (intel#724) This reverts commit 367e10e. Reverting due to intel/llvm#4966 revert.
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
…ess spaces (intel/llvm-test-suite#570) Remove xfail from tests fixed by: intel#4966
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
…t_t address spaces (intel/llvm-test-suite#570)" (intel/llvm-test-suite#724) This reverts commit d2ed0fc. Reverting due to intel#4966 revert.
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
…ong event_t address spaces (intel/llvm-test-suite#570)" (intel/llvm-test-suite#724)" (intel/llvm-test-suite#732) This reverts commit 7883645. The failing test is fixed by intel#5293.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove xfail from tests fixed by: intel/llvm#4966