This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[SYCL] tests to support new sycl::span deduction guide fix #572
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…construction with type deduction for array args. Here the tests are updated to support this new addition. Signed-off-by: Chris Perkins <[email protected]>
|
/verify with intel/llvm#4970 |
vladimirlaz
approved these changes
Nov 17, 2021
s-kanaev
approved these changes
Nov 17, 2021
|
@s-kanaev - by "have such a test as an in-tree LIT test" do you mean move this test back to intel/llvm as part of the SYCL test suite there? Yes, easily. Let me know if I understand you correctly. |
|
@cperkinsintel it looks like there is no reason to add the regression test for the issue here. The problem is exposed on compile-time and can be checked in check-sycl. |
bader
pushed a commit
to intel/llvm
that referenced
this pull request
Nov 30, 2021
The sycl::span does not correctly deduce the type from an array argument. Here we fix this by adjusting the deduction guide to select the correct specialization (that has array support). The tests on llvm-test-suite are being updated as well. ( intel/llvm-test-suite#572 ) Signed-off-by: Chris Perkins <[email protected]>
|
moving test to check-sycl intel/llvm#5056 . Closing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
deduction guide for sycl::span has been updated to correctly support construction with type deduction for array args. Here the tests are updated to support this new addition.
Fix on intel/llvm: intel/llvm#4970
This test change cannot pass without the above PR. Here you can see the two run against each other and passing successfully: http://icl-jenkins.sc.intel.com:8080/job/SYCL_CI/job/intel/job/Lin/job/LLVM_Test_Suite/7736/
Signed-off-by: Chris Perkins [email protected]