Skip to content
This repository was archived by the owner on Mar 28, 2023. It is now read-only.

[SYCL] Fix memory leak in SYCL/Basic/get_backend.cpp #585

Merged
merged 1 commit into from
Dec 21, 2021

Conversation

bso-intel
Copy link

The test is missing the call to free().

Signed-off-by: Byoungro So [email protected]

Signed-off-by: Byoungro So <[email protected]>
@bso-intel bso-intel requested a review from a team as a code owner November 25, 2021 03:13
@dm-vodopyanov dm-vodopyanov changed the title fixed memory leak [SYCL] Fix memory leak in SYCL/Basic/get_backend.cpp Nov 25, 2021
Copy link

@dm-vodopyanov dm-vodopyanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vladimirlaz
Copy link

@bso-intel, it looks like modified test fails unexpectedly on OpenCL. Could you please fix the issue?

@bso-intel
Copy link
Author

@bso-intel, it looks like modified test fails unexpectedly on OpenCL. Could you please fix the issue?

Hi @vladimirlaz ,
I reran the test Jinkins/pre-ci-linux and the failure in get_backend.cpp is gone now.
But, there is another failure test "SYCL :: DiscardEvents/invalid_event.cpp".
This should not be related to my memory leak fix in get_backend.cpp test.

@vladimirlaz vladimirlaz merged commit ff52f2b into intel:intel Dec 21, 2021
@bso-intel bso-intel deleted the get-backend branch January 6, 2022 06:10
aelovikov-intel pushed a commit to aelovikov-intel/llvm that referenced this pull request Mar 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants