This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[SYCL][ESIMD] Add function that let iterating over types and dims #588
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was added function for_types_and_dims and was updated "ctor_default" test
yuriykoch
reviewed
Dec 10, 2021
- New struct names with lesser character names provides write our statements in one string - Now ctor_copy.cpp used "for_all_types_and_dims" function
- Add factory method get_tested_dimensions, so we have same logic with retreiving tested types - Reverted comment that how "for_all_types" works
yuriykoch
reviewed
Dec 13, 2021
yuriykoch
reviewed
Dec 13, 2021
- Updated comments - Removed unnecessary variable
|
@sndmitriev Could you review this PR? |
|
@sndmitriev I am not authorized to merge this PR, could you merge it? |
Neither do I. @kbobrovs, can you please merge this PR? |
v-klochkov
approved these changes
Dec 15, 2021
|
@v-klochkov @sndmitriev thanks Vyacheslav and Serguei |
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
…tel/llvm-test-suite#588) * [SYCL][ESIMD] Add functions that let iterating over types and dims - Added function for_types_and_dims and was updated "ctor_default" test - New struct names with lesser character names provides write our statements in one string - Now ctor_copy.cpp used "for_all_types_and_dims" function - Add factory method get_tested_dimensions, so we have same logic with retreiving tested types - Reverted comment that how "for_all_types" works
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new version of
for_all_typeswill be useful in tests forsimdThis feature lets us avoid using a lots of aliases duplicating instead of this just using
values_pack, it can be found hereThe testing result is the same as before using this feature