Skip to content
This repository was archived by the owner on Mar 28, 2023. It is now read-only.

[SYCL] [FPGA] Create DSP control E2E emulator test #591

Merged
merged 2 commits into from
Dec 2, 2021

Conversation

shuoniu-intel
Copy link

@shuoniu-intel shuoniu-intel commented Nov 29, 2021

Create E2E emulator test for newly added DSP control header.

The corresponding SYCL PR: intel/llvm#5035

@shuoniu-intel
Copy link
Author

/verify with intel/llvm#5035

@DoyleLi
Copy link

DoyleLi commented Nov 30, 2021

/verify with intel/llvm#5035

@romanovvlad
Copy link

@MrSidims @mlychkov Could you please review?

romanovvlad pushed a commit to intel/llvm that referenced this pull request Nov 30, 2021
Create header file that provides user API for FPGA DSP control feature.

Related links:

    SPIR-V spec: https://github.com/KhronosGroup/SPIRV-Registry/blob/main/extensions/INTEL/SPV_INTEL_fpga_dsp_control.asciidoc
    SPIR-V implementation: 

    [SPIRV] New FPGA function attribute for DSP control KhronosGroup/SPIRV-LLVM-Translator#1046

Test: intel/llvm-test-suite#591
@shuoniu-intel
Copy link
Author

Note that the new test Basic/fpga_tests/fpga_dsp_control.cpp passed in Jenkins/llvm-test-suite: http://llvm-ci-test2.intel.com:8080/blue/organizations/jenkins/SYCL_CI%2Fintel%2FLin%2FLLVM_Test_Suite_CUDA/detail/LLVM_Test_Suite_CUDA/80/pipeline/#step-239-log-156.

Copy link

@MrSidims MrSidims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test is LGTM, just comments to the run strings

@shuoniu-intel
Copy link
Author

/verify with intel/llvm#5035

@shuoniu-intel
Copy link
Author

Both fpga_dsp_control.cpp and fpga_lsu.cpp passed compile and run in the latest Jenkins/llvm-test-suite.
@MrSidims @mlychkov Please review.

Copy link

@mlychkov mlychkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shuoniu-intel Thank you.

@vladimirlaz vladimirlaz merged commit eef10f9 into intel:intel Dec 2, 2021
@shuoniu-intel shuoniu-intel deleted the dsp-control-e2e branch December 2, 2021 14:34
aelovikov-intel pushed a commit to aelovikov-intel/llvm that referenced this pull request Mar 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants