Disable -fsycl-dead-args-optimization for separate compilation test #595
Conversation
As we move to making -fsycl-dead-args-optimization the default, we need to disable for separate compilation testing, as we are not performing the additional sycl-post-link step here.
mdtoguchi
requested review from
AGindinson,
AlexeySachkov,
dm-vodopyanov and
romanovvlad
as code owners
There was a problem hiding this comment.
The change LGTM. A question with regard to the test itself, though: how representative is it now that we have so many features relying on additional tools & the information they convey to the runtime? Should we consider shying away from this "per-tool" type of compilation in the E2E test, possibly introducing additional tests for various separate compilation/linkage cases, all based on compiler driver invocations?
I think representation of this test (and possibly other separate tool compilation tests) via driver invocations is a good direction.. |
|
Failures seen have nothing to do with my test modification. |
…ntel/llvm-test-suite#595) As we move to making -fsycl-dead-args-optimization the default, we need to disable for separate compilation testing, as we are not performing the additional sycl-post-link step here.
As we move to making -fsycl-dead-args-optimization the default, we need
to disable for separate compilation testing, as we are not performing
the additional sycl-post-link step here.