This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[SYCL][ESIMD] Add test for esimd fill constructor #598
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test was splitted into two files: - core, that iterating only C++ with base data types - fp_extra, that itarating with sycl::half data type
yuriykoch
reviewed
Dec 9, 2021
yuriykoch
reviewed
Dec 10, 2021
- run_test and verification function defined in ctor_fill.hpp - add class for structurize log error message - rename some function and variables - remove initialization
- update ctor_fill.hpp - rename some variables - add test for vector ctor accuracy
Because it didn't used in this test
yuriykoch
reviewed
Dec 24, 2021
- Change logic forverification if base or step value is nan and all other cases - Update static_assert messages
Use value::pos_ulp() in ctor fill test instead of using value::ulp()
- Rename values_pack with two dims - Update comments - Remove unused args
yuriykoch
reviewed
Dec 27, 2021
SYCL/ESIMD/api/functional/ctors/ctor_fill_accuracy_fp_extra.cpp
Outdated
Show resolved
Hide resolved
- Remove bitwise comparison in case step or base value is nan - Remove unnecessary using namespace ... - Update comments
yuriykoch
reviewed
Dec 28, 2021
Move comments before code that it describe
|
@v-klochkov Vyacheslav, could you review this PR? |
v-klochkov
reviewed
Jan 4, 2022
v-klochkov
reviewed
Jan 4, 2022
v-klochkov
reviewed
Jan 4, 2022
| // XRUN: %GPU_RUN_PLACEHOLDER %t.out | ||
| // RUN: false | ||
| // XFAIL: * | ||
| // TODO The simd can't be constructed with sycl::half data type. The issue was |
There was a problem hiding this comment.
Please try the newer compiler. sycl::half should be working fine with simd now.
There was a problem hiding this comment.
This discuss related to all tests, so suggest discuss it in the one place, in this your comment: discussion in PR#687
v-klochkov
reviewed
Jan 4, 2022
|
|
||
| bool passed = true; | ||
|
|
||
| const auto fp_types = get_tested_types<tested_types::fp_extra>(); |
There was a problem hiding this comment.
The types like sycl::half need runtime checks verifying that device supports them. E.g. sycl::aspect::fp16
There was a problem hiding this comment.
fp_extra files was temporary removed and the sycl::half data type was enable for all tests, I've done it this commit: 716223f
v-klochkov
reviewed
Jan 4, 2022
v-klochkov
reviewed
Jan 10, 2022
v-klochkov
reviewed
Jan 10, 2022
v-klochkov
approved these changes
Jan 10, 2022
|
@v-klochkov all CI verifications are passed. Can we merge this PR? |
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
…ite#598) * [SYCL][ESIMD] Add test for simd fill constructor The test currently verifies the basic types; it does not yet check types requiring checks "if supported on device", such as "sycl::half". Also, the test does not yet verify 32-element vectors due to existing runtime problems in either device drivers or ESIMD implementation.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.