This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[SYCL] Adds regression test for reduction resource leak #624
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Select variants of reductions currently leak additional resources, such as auxiliary buffers. This commit adds a regression test to ensure this leak does not resurface. Signed-off-by: Steffen Larsen <[email protected]>
steffenlarsen
requested review from
bader,
romanovvlad and
vladimirlaz
as code owners
Signed-off-by: Steffen Larsen <[email protected]>
Signed-off-by: Steffen Larsen <[email protected]>
romanovvlad
reviewed
Dec 17, 2021
Co-authored-by: Romanov Vlad <[email protected]>
|
/verify with intel/llvm#5653 |
|
/verify with intel/llvm#5653 |
|
intel/llvm#5653 has been merged and verification with it passed. @vladimirlaz & @romanovvlad - Could you please have another look at this? |
vladimirlaz
previously approved these changes
Mar 18, 2022
Look OK, but don't we want to test USM case? |
Signed-off-by: Steffen Larsen <[email protected]>
|
@romanovvlad - I have added a USM test case. |
Signed-off-by: Steffen Larsen <[email protected]>
Signed-off-by: Steffen Larsen <[email protected]>
romanovvlad
approved these changes
Mar 21, 2022
myler
pushed a commit
to myler/llvm-test-suite
that referenced
this pull request
Apr 12, 2022
[SYCL] Test rework for SYCL_DEVICE_FILTER=device_num
myler
pushed a commit
to myler/llvm-test-suite
that referenced
this pull request
Jun 17, 2022
Select variants of reductions currently leak additional resources, such as auxiliary buffers. This commit adds a regression test to ensure this leak does not resurface. Signed-off-by: Steffen Larsen <[email protected]>
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
…est-suite#624) Select variants of reductions currently leak additional resources, such as auxiliary buffers. This commit adds a regression test to ensure this leak does not resurface. Signed-off-by: Steffen Larsen <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Select variants of reductions currently leak additional resources, such as auxiliary buffers. This commit adds a regression test to ensure this leak does not resurface.
Fix: intel/llvm#5653