This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[SYCL] Temporary disable of DeviceLib tests #625
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disabled tests: SYCL/DeviceLib/built-ins/vector_relational.cpp, SYCL/DeviceLib/cmath_fp64_test.cpp, SYCL/DeviceLib/cmath_test.cpp, SYCL/DeviceLib/math_fp64_test.cpp, SYCL/DeviceLib/math_test.cpp
|
Can you please explain why you have to do it? |
All the last PRs to llvm-test-suite fail on these tests. |
dm-vodopyanov
previously approved these changes
Dec 17, 2021
|
Can you also please disable Assert tests in separate PR? Please add links to these PRs to appropriate internal tickets. |
I think disabling the assert tests is unnecessary because the latest PRs into llvm-test-suite don't fails on asserts anymore (maybe, they are already fixed). |
vladimirlaz
approved these changes
Dec 20, 2021
This was referenced Dec 20, 2021
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disabled tests: SYCL/DeviceLib/built-ins/vector_relational.cpp, SYCL/DeviceLib/cmath_fp64_test.cpp, SYCL/DeviceLib/cmath_test.cpp, SYCL/DeviceLib/math_fp64_test.cpp, SYCL/DeviceLib/math_test.cpp