This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[SYCL] fix memory leak #646
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Byoungro So <[email protected]>
vladimirlaz
reviewed
Dec 21, 2021
| @@ -109,6 +109,7 @@ int main() { | |||
| std::cerr << "Total mismatch = " << err_cnt << std::endl; | |||
| return 1; | |||
| } | |||
| free(A, ctx); | |||
There was a problem hiding this comment.
shouldn't we free this memory in case of the test failures. see line 110?
There was a problem hiding this comment.
Moving the free to line 107 (right after the loop) should do the trick.
Signed-off-by: Byoungro So <[email protected]>
vladimirlaz
approved these changes
Dec 22, 2021
myler
pushed a commit
to myler/llvm-test-suite
that referenced
this pull request
Apr 12, 2022
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
Signed-off-by: Byoungro So <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added missing free call to fix memory leak.
Signed-off-by: Byoungro So [email protected]