This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[SYCL] Rename deprecated access::target::global_buffer #647
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 21, 2021 11:41
The sycl::access::target::global_buffer enumeration is deprecated in SYCL 2020, the target::device one should be used instead. Signed-off-by: Pavel Samolysov <[email protected]>
Signed-off-by: Pavel Samolysov <[email protected]>
Signed-off-by: Pavel Samolysov <[email protected]>
ghost
marked this pull request as ready for review
ghost
requested review from
AlexeySachkov,
Fznamznon,
kbobrovs,
Pennycook,
sndmitriev,
v-klochkov,
vzakhari and
a team
as code owners
AlexeySachkov
approved these changes
Dec 22, 2021
Fznamznon
approved these changes
Dec 24, 2021
Pennycook
reviewed
Jan 5, 2022
| cl::sycl::access::target::global_buffer>; | ||
| cl::sycl::access::target::device>; |
There was a problem hiding this comment.
Moving from SYCL 1.2.1 to SYCL 2020 should change three things about this line:
- The
cl::sycl::namespace should besycl::instead, sincecl::comes in only via<CL/sycl.hpp> sycl::access::targetshould besycl::targetbecause the former is deprecated (see here)global_buffershould bedevice(as changed in your patch)
Is there a reason to only make the global_buffer => device change here?
There was a problem hiding this comment.
@Pennycook Yes, the reason is just to change global_buffer => device here, moving from SYCL 1.2.1 to SYCL 2020 is a more global initiative.
There was a problem hiding this comment.
Ok. I still think moving these things to the right namespace now would save time, but I won't argue.
There was a problem hiding this comment.
I see, there is a mix of the cl::sycl:: and just sycl:: namespaces in this file, for example it uses cl::sycl:: for access::target or property, but sycl:: for ::access::mode or buffer, or id. I'm going to fix the namespace mismatch in another PR.
Pennycook
approved these changes
Jan 10, 2022
v-klochkov
approved these changes
Jan 10, 2022
myler
pushed a commit
to myler/llvm-test-suite
that referenced
this pull request
Apr 12, 2022
The sycl::access::target::global_buffer enumeration is deprecated in SYCL 2020, the target::device one should be used instead. Signed-off-by: Pavel Samolysov <[email protected]>
myler
pushed a commit
to myler/llvm-test-suite
that referenced
this pull request
Apr 12, 2022
The sycl::access::target::global_buffer enumeration is deprecated in SYCL 2020, the target::device one should be used instead. Signed-off-by: Pavel Samolysov <[email protected]>
myler
pushed a commit
to myler/llvm-test-suite
that referenced
this pull request
Jun 17, 2022
The sycl::access::target::global_buffer enumeration is deprecated in SYCL 2020, the target::device one should be used instead. Signed-off-by: Pavel Samolysov <[email protected]>
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
…st-suite#647) The sycl::access::target::global_buffer enumeration is deprecated in SYCL 2020, the target::device one should be used instead. Signed-off-by: Pavel Samolysov <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sycl::access::target::global_buffer enumeration is deprecated in SYCL 2020,
the target::device one should be used instead.
Signed-off-by: Pavel Samolysov [email protected]