This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[SYCL] Disable Signbit issue for NAN #653
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jinge90 <[email protected]>
|
Hi, @vladimirlaz Thanks very much. |
vladimirlaz
suggested changes
Dec 22, 2021
Signed-off-by: jinge90 <[email protected]>
Hi, @vladimirlaz I just used "clang-format-9 cmath_fp64_test.cpp" to get the clang formatted patch. Thanks very much. |
|
Hi, @intel/llvm-reviewers-runtime @vladimirlaz @vzakhari |
vladimirlaz
changed the title
|
@jinge90 it looks like test coverage has been reduced. Could you please provide motivation in the PR description? |
vladimirlaz
approved these changes
Jan 12, 2022
myler
pushed a commit
to myler/llvm-test-suite
that referenced
this pull request
Apr 12, 2022
Disabled test cases impacted by the fact that Clang and MSVC compilers have different behavior for sign bit of NAN/-NAN. Signed-off-by: jinge90 <[email protected]>
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
Disabled test cases impacted by the fact that Clang and MSVC compilers have different behavior for sign bit of NAN/-NAN. Signed-off-by: jinge90 <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disabled test cases impacted by the fact that Clang and MSVC compilers have different behavior for sign bit of NAN/-NAN.
Signed-off-by: jinge90 [email protected]