This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[SYCL] Disable tests failing in CI #668
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladimirlaz
requested review from
bader,
kbobrovs,
romanovvlad,
sndmitriev,
v-klochkov and
a team
as code owners
bader
reviewed
Dec 23, 2021
bader
reviewed
Dec 23, 2021
bader
approved these changes
Dec 23, 2021
There was a problem hiding this comment.
Thanks!
LGTM, although I would check with @alexbatashev if XFAIL is the right way to disable SYCL/XPTI/basic_event_collection.cpp or we should also apply UNSUPPORTED to be able to fix the compiler w/o breaking CI (if needed).
alexbatashev
previously approved these changes
Dec 23, 2021
SYCL/XPTI/basic_event_collection.cpp
Outdated
Comment on lines
6
to
7
| // It looks like order of events diffres on Windows | ||
| // XFAIL: windows |
There was a problem hiding this comment.
I think writing a single test here gets too complex. We should probably simply have two distinct files for each of OSes, like we do for some other tests.
There was a problem hiding this comment.
I will update the XPTI related tests. To have them smaller.
bader
suggested changes
Dec 23, 2021
alexbatashev
previously approved these changes
Dec 23, 2021
Co-authored-by: Alexey Bader <[email protected]>
alexbatashev
approved these changes
Dec 23, 2021
bader
approved these changes
Dec 23, 2021
myler
pushed a commit
to myler/llvm-test-suite
that referenced
this pull request
Apr 12, 2022
…ith LevelZero. It is 'unexpectedly passing' for xmain, so am re-enabling this test for LevelZero. Will need to enable for SYCLOS at a later date (as the CI system there has not yet been updated to agama-676). (intel#668) Signed-off-by: Chris Perkins <[email protected]>
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.