This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[SYCL][ESIMD] Add test on simd broadcast constructor #690
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasilytric
commented
Dec 28, 2021
vasilytric
commented
- In this PR was used utility-function for obtaining reference data. It lets avoid code copy-pasteing
- Was added function for obtaining reference data that depends on two data types
It removes duplicated code
This function provides reference data in the tests that uses a few data types.
yuriykoch
reviewed
Dec 28, 2021
- Remove using ctor namespace, use "ctor::" insted - Fix logic with definin type in simd vector - Change test result verification logic
Because std::is_signed can't handle sycl::half
- Add comments
yuriykoch
reviewed
Feb 14, 2022
- Change error output - Rename variables
yuriykoch
reviewed
Feb 16, 2022
|
@sndmitriev Would you mind to review this PR? |
sndmitriev
approved these changes
Feb 22, 2022
|
@kbobrovs Would you mind to merge this PR? |
myler
pushed a commit
to myler/llvm-test-suite
that referenced
this pull request
Apr 12, 2022
* [SYCL][ESIMD] Add test on simd broadcast constructor
myler
pushed a commit
to myler/llvm-test-suite
that referenced
this pull request
Jun 17, 2022
* [SYCL][ESIMD] Add test on simd broadcast constructor
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
…st-suite#690) * [SYCL][ESIMD] Add test on simd broadcast constructor
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.