This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[SYCL][ESIMD] Add test on simd converting constructor #695
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change run_test signature - Add add expected test cases - Update comments
This update required for case when current value is demoralized because the rule of rounding on the host and device sides is undefined.
yuriykoch
reviewed
Mar 4, 2022
- Update comments, add TODO comment - Verify that one value is nan, instead of verify tha both values is nan - Add additional constructor calling contexts
|
@v-klochkov Would you mind to take a look? |
v-klochkov
reviewed
Mar 9, 2022
v-klochkov
previously approved these changes
Mar 10, 2022
v-klochkov
approved these changes
Mar 11, 2022
myler
pushed a commit
to myler/llvm-test-suite
that referenced
this pull request
Apr 12, 2022
myler
pushed a commit
to myler/llvm-test-suite
that referenced
this pull request
Apr 12, 2022
- Change run_test signature - Add add expected test cases - This update required for case when current value is demoralized because the rule of rounding on the host and device sides is undefined. - Verify that one value is nan, instead of verify thaе both values is nan - Add additional constructor calling contexts - Add coverage for 1 simd size - Enable test for fp_extra types - Use new esimd namespace
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
…t-suite#695) - Change run_test signature - Add add expected test cases - This update required for case when current value is demoralized because the rule of rounding on the host and device sides is undefined. - Verify that one value is nan, instead of verify thaе both values is nan - Add additional constructor calling contexts - Add coverage for 1 simd size - Enable test for fp_extra types - Use new esimd namespace
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.