[SYCL] fix memory leak #705
Conversation
Signed-off-by: Byoungro So <[email protected]>
| @@ -63,8 +63,10 @@ int main() { | |||
| unsigned char *HostAlloc = (unsigned char *)malloc_host(1, c); | |||
| auto e = q.memset(HostAlloc, 42, 1); | |||
| if (e.get_backend() != plt.get_backend()) { | |||
| free(HostAlloc, c); | |||
There was a problem hiding this comment.
Since HostAlloc is freed no matter which path is taken here, could they be unified before the if?
There was a problem hiding this comment.
Done. I was not sure if it is safe to free memory before e.get_backend() because e is associated with HostAlloc USM memory.
There was a problem hiding this comment.
I believe freeing will synchronize with the event, but from there it should be valid even after related resources are freed. Until recently you would have to do an explicit wait for e before freeing, but in that case the previous code would be broken as well. If you want peace of mind you can call and store e.get_backend ahead of freeing and then use the result in the if, but I'd argue if it didn't work as-is it is a bug. 😄
Signed-off-by: Byoungro So <[email protected]>
Signed-off-by: Byoungro So <[email protected]>
Add calls to free() to release memory properly.
Signed-off-by: Byoungro So [email protected]