Skip to content
This repository was archived by the owner on Mar 28, 2023. It is now read-only.

[SYCL] xfail on zedebug #707

Merged
merged 1 commit into from
Jan 10, 2022
Merged

[SYCL] xfail on zedebug #707

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions SYCL/DeprecatedFeatures/program-merge-options-env.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
// RUN: env SYCL_PI_TRACE=-1 SYCL_PROGRAM_COMPILE_OPTIONS=-DENV_COMPILE_OPTS SYCL_PROGRAM_LINK_OPTIONS=-DENV_LINK_OPTS SYCL_DEVICE_FILTER=%sycl_be %t.out | FileCheck %s
// REQUIRES: gpu
// UNSUPPORTED: cuda || hip
// XFAIL: ze_debug-1,ze_debug4
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bso-intel - The XFAIL directive means the test will still be run, just expected to fail. Whereas the UNSUPPORTED directive prevents the test from ever being run. In this PR you are trying to prevent a memory leak on the CI system, no? If so, wouldn't using the UNSUPPORTED mechanism be better?

Also, if this is a temporary change while we await a fix, it might be best to also add a comment saying that to the test itself, rather than just the PR, so it doesn't get overlooked in the future.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know we could use //UNSUPPORTED, but we decided to use //XFAIL.
//XFAIL is exactly for this purpose to run it and find out if it passes some day in the future.
ze_debug-1 and ze_debug4 are all temporary markers.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cperkinsintel , please refer to #704.
I just add two more tests that are missed from PR-704.

#include "program-merge-options.hpp"

// CHECK: piProgramBuild
Expand Down
2 changes: 1 addition & 1 deletion SYCL/DeprecatedFeatures/program-merge-options.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

// Debug option -g is not passed to device code compiler when CL-style driver
// is used and /DEBUG options is passed.
// XFAIL: cl_options
// XFAIL: cl_options,ze_debug-1,ze_debug4
#include "program-merge-options.hpp"

// CHECK: piProgramBuild
Expand Down