Skip to content
This repository was archived by the owner on Mar 28, 2023. It is now read-only.

[SYCL][ESIMD] Provide the for_all_combinations utility #721

Merged
merged 9 commits into from
Jan 28, 2022

Conversation

yuriykoch
Copy link

@yuriykoch yuriykoch commented Jan 11, 2022

Provides a generic way to represent a combinations of types and compile-time
values to cover. Supports any number of type and value packs to iterate over,
with any combination of named and unnamed type packs and value packs
possible

Signed-off-by: Kochetkov, Yuriy [email protected]

To ensure more complex logic resides nearby each other

Signed-off-by: Kochetkov, Yuriy <[email protected]>
Provides a generic way to represent a combinations of types and compile-time
values to cover. Supports any number of type and value packs to iterate over

Signed-off-by: Kochetkov, Yuriy <[email protected]>
The newer version should be used instead of clang-format-10

Signed-off-by: Kochetkov, Yuriy <[email protected]>
By doing so we avoid additional restriction on architecture of
the test case functors and on logging architecture, as we don't
need to construct string description for every type/value on the
top level.
We are still free to use named type packs, giving us a possibility
to have any combination of named packs and unnamed packs, with value
packs supported in both variations.
Tests are updated as there is no more for_all_types_and_dims function

Signed-off-by: Kochetkov, Yuriy <[email protected]>
Signed-off-by: Kochetkov, Yuriy <[email protected]>
To enable CI verification for the ctor_copy test

Signed-off-by: Kochetkov, Yuriy <[email protected]>
@yuriykoch
Copy link
Author

@sndmitriev Would you mind to take a look?

@yuriykoch
Copy link
Author

Merge conflicts resolved. @sndmitriev Friendly ping

@yuriykoch
Copy link
Author

@kbobrovs PR is ready to merge

@kbobrovs kbobrovs merged commit 6870ea3 into intel:intel Jan 28, 2022
myler pushed a commit to myler/llvm-test-suite that referenced this pull request Apr 12, 2022
[SYCL][ESIMD] Provide the for_all_combinations utility

Provides a generic way to represent a combinations of types and compile-time
values to cover. Supports any number of type and value packs to iterate over

Adds unnamed type pack support

By doing so we avoid additional restriction on architecture of
the test case functors and on logging architecture, as we don't
need to construct string description for every type/value on the
top level.
We are still free to use named type packs, giving us a possibility
to have any combination of named packs and unnamed packs, with value
packs supported in both variations.
Tests are updated as there is no more for_all_types_and_dims function

Signed-off-by: Kochetkov, Yuriy <[email protected]>
myler pushed a commit to myler/llvm-test-suite that referenced this pull request Jun 17, 2022
[SYCL][ESIMD] Provide the for_all_combinations utility

Provides a generic way to represent a combinations of types and compile-time
values to cover. Supports any number of type and value packs to iterate over

Adds unnamed type pack support

By doing so we avoid additional restriction on architecture of
the test case functors and on logging architecture, as we don't
need to construct string description for every type/value on the
top level.
We are still free to use named type packs, giving us a possibility
to have any combination of named packs and unnamed packs, with value
packs supported in both variations.
Tests are updated as there is no more for_all_types_and_dims function

Signed-off-by: Kochetkov, Yuriy <[email protected]>
aelovikov-intel pushed a commit to aelovikov-intel/llvm that referenced this pull request Mar 27, 2023
…st-suite#721)

[SYCL][ESIMD] Provide the for_all_combinations utility

Provides a generic way to represent a combinations of types and compile-time
values to cover. Supports any number of type and value packs to iterate over

Adds unnamed type pack support

By doing so we avoid additional restriction on architecture of
the test case functors and on logging architecture, as we don't
need to construct string description for every type/value on the
top level.
We are still free to use named type packs, giving us a possibility
to have any combination of named packs and unnamed packs, with value
packs supported in both variations.
Tests are updated as there is no more for_all_types_and_dims function

Signed-off-by: Kochetkov, Yuriy <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants