This repository was archived by the owner on Mar 28, 2023. It is now read-only.
forked from llvm/llvm-test-suite
-
Notifications
You must be signed in to change notification settings - Fork 130
[SYCL][ESIMD] Provide the for_all_combinations utility #721
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To ensure more complex logic resides nearby each other Signed-off-by: Kochetkov, Yuriy <[email protected]>
Provides a generic way to represent a combinations of types and compile-time values to cover. Supports any number of type and value packs to iterate over Signed-off-by: Kochetkov, Yuriy <[email protected]>
vasilytric
reviewed
Jan 11, 2022
Signed-off-by: Kochetkov, Yuriy <[email protected]>
The newer version should be used instead of clang-format-10 Signed-off-by: Kochetkov, Yuriy <[email protected]>
Signed-off-by: Kochetkov, Yuriy <[email protected]>
By doing so we avoid additional restriction on architecture of the test case functors and on logging architecture, as we don't need to construct string description for every type/value on the top level. We are still free to use named type packs, giving us a possibility to have any combination of named packs and unnamed packs, with value packs supported in both variations. Tests are updated as there is no more for_all_types_and_dims function Signed-off-by: Kochetkov, Yuriy <[email protected]>
Signed-off-by: Kochetkov, Yuriy <[email protected]>
To enable CI verification for the ctor_copy test Signed-off-by: Kochetkov, Yuriy <[email protected]>
@sndmitriev Would you mind to take a look? |
Merge conflicts resolved. @sndmitriev Friendly ping |
sndmitriev
approved these changes
Jan 28, 2022
@kbobrovs PR is ready to merge |
myler
pushed a commit
to myler/llvm-test-suite
that referenced
this pull request
Apr 12, 2022
[SYCL][ESIMD] Provide the for_all_combinations utility Provides a generic way to represent a combinations of types and compile-time values to cover. Supports any number of type and value packs to iterate over Adds unnamed type pack support By doing so we avoid additional restriction on architecture of the test case functors and on logging architecture, as we don't need to construct string description for every type/value on the top level. We are still free to use named type packs, giving us a possibility to have any combination of named packs and unnamed packs, with value packs supported in both variations. Tests are updated as there is no more for_all_types_and_dims function Signed-off-by: Kochetkov, Yuriy <[email protected]>
myler
pushed a commit
to myler/llvm-test-suite
that referenced
this pull request
Jun 17, 2022
[SYCL][ESIMD] Provide the for_all_combinations utility Provides a generic way to represent a combinations of types and compile-time values to cover. Supports any number of type and value packs to iterate over Adds unnamed type pack support By doing so we avoid additional restriction on architecture of the test case functors and on logging architecture, as we don't need to construct string description for every type/value on the top level. We are still free to use named type packs, giving us a possibility to have any combination of named packs and unnamed packs, with value packs supported in both variations. Tests are updated as there is no more for_all_types_and_dims function Signed-off-by: Kochetkov, Yuriy <[email protected]>
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
…st-suite#721) [SYCL][ESIMD] Provide the for_all_combinations utility Provides a generic way to represent a combinations of types and compile-time values to cover. Supports any number of type and value packs to iterate over Adds unnamed type pack support By doing so we avoid additional restriction on architecture of the test case functors and on logging architecture, as we don't need to construct string description for every type/value on the top level. We are still free to use named type packs, giving us a possibility to have any combination of named packs and unnamed packs, with value packs supported in both variations. Tests are updated as there is no more for_all_types_and_dims function Signed-off-by: Kochetkov, Yuriy <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides a generic way to represent a combinations of types and compile-time
values to cover. Supports any number of type and value packs to iterate over,
with any combination of named and unnamed type packs and value packs
possible
Signed-off-by: Kochetkov, Yuriy [email protected]