This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[SYCL] Adds test for selective building in implicit kernel bundles #726
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In select cases the SYCL runtime may create an implicit kernel bundle to for example track specialization constants. These kernel bundles should only build the device image that contains the kernel being launched. This commit adds a test for checking that only one device image is built by an implicit kernel bundle when only a single kernel is launched and using per-kernel device-code splitting. Signed-off-by: Steffen Larsen <[email protected]>
Signed-off-by: Steffen Larsen <[email protected]>
|
@v-klochkov & @vladimirlaz - intel/llvm#5285 was merged so this should be ready to merge. |
|
@steffenlarsen the test is failing on cuda (I guess it will fail on hip and esimd_emulator as well) |
Signed-off-by: Steffen Larsen <[email protected]>
vladimirlaz
approved these changes
Feb 14, 2022
myler
pushed a commit
to myler/llvm-test-suite
that referenced
this pull request
Apr 12, 2022
…ntel#726) * In select cases the SYCL runtime may create an implicit kernel bundle to for example track specialization constants. These kernel bundles should only build the device image that contains the kernel being launched. This commit adds a test for checking that only one device image is built by an implicit kernel bundle when only a single kernel is launched and using per-kernel device-code splitting. * Disable on CUDA and HIP Signed-off-by: Steffen Larsen <[email protected]>
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
…ntel/llvm-test-suite#726) * In select cases the SYCL runtime may create an implicit kernel bundle to for example track specialization constants. These kernel bundles should only build the device image that contains the kernel being launched. This commit adds a test for checking that only one device image is built by an implicit kernel bundle when only a single kernel is launched and using per-kernel device-code splitting. * Disable on CUDA and HIP Signed-off-by: Steffen Larsen <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In select cases the SYCL runtime may create an implicit kernel bundle to for example track specialization constants. These kernel bundles should only build the device image that contains the kernel being launched.
This commit adds a test for checking that only one device image is built by an implicit kernel bundle when only a single kernel is launched and using per-kernel device-code splitting.
Test fix: intel/llvm#5285