Skip to content
This repository was archived by the owner on Mar 28, 2023. It is now read-only.

[SYCL][CUDA] Add tests for asynchronous barrier #737

Merged
merged 7 commits into from
May 17, 2022

Conversation

t4c1
Copy link

@t4c1 t4c1 commented Jan 13, 2022

Adds tests for intel/llvm#5303

Copy link

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests look good. I've added some small comments.

One concern is that the the interface test case includes a lot in a single kernel. If that test fails it may be hard to determine which part of the test caused the failure. Would it make sense to either split it up or save and validate intermediate results to help isolate the failing operations?

@t4c1
Copy link
Author

t4c1 commented May 3, 2022

I can split the test into multiple kernels, but a large amount of code (more or less the whole basic test) would need to be duplicated in each test.

@steffenlarsen
Copy link

I can split the test into multiple kernels, but a large amount of code (more or less the whole basic test) would need to be duplicated in each test.

Is there no good way of reducing common code for the cases? If it isn't worth it, I am okay with keeping the test as-is.

@t4c1
Copy link
Author

t4c1 commented May 3, 2022

I think at best I can reduce the amount of code duplication (but not eliminate it) at cost of making the code a bit harder to read. I would prefer to leave this as is, as it is unlikely that implementation of something changes in a way that would break semantics but not interface.

@t4c1 t4c1 requested a review from steffenlarsen May 3, 2022 12:38
pvchupin pushed a commit to intel/llvm that referenced this pull request May 17, 2022
Adds extension proposal and implementation for asynchronous barrier (for now the implementation is for CUDA backend sm 80+ only).

Tests for this are here: intel/llvm-test-suite#737
@pvchupin pvchupin merged commit 533dc7a into intel:intel May 17, 2022
yinyangsx pushed a commit to yinyangsx/llvm that referenced this pull request May 25, 2022
Adds extension proposal and implementation for asynchronous barrier (for now the implementation is for CUDA backend sm 80+ only).

Tests for this are here: intel/llvm-test-suite#737
@t4c1 t4c1 deleted the async_barrier branch May 27, 2022 06:52
myler pushed a commit to myler/llvm-test-suite that referenced this pull request Jun 17, 2022
aelovikov-intel pushed a commit to aelovikov-intel/llvm that referenced this pull request Mar 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants