This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[SYCL][ESIMD] Add tests on simd copy and move assignment operators #762
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuriykoch
reviewed
Jan 24, 2022
SYCL/ESIMD/api/functional/ctors/operator_assignment_copy_core.cpp
Outdated
Show resolved
Hide resolved
SYCL/ESIMD/api/functional/ctors/operator_assignment_copy_core.cpp
Outdated
Show resolved
Hide resolved
SYCL/ESIMD/api/functional/ctors/operator_assignment_move_core.cpp
Outdated
Show resolved
Hide resolved
- Use header with werifecation function it lets avoid code copy-paste - Update comments
yuriykoch
reviewed
Jan 25, 2022
SYCL/ESIMD/api/functional/ctors/operator_assignment_copy_core.cpp
Outdated
Show resolved
Hide resolved
- Update comemnts - Now shared_elem used only with one elem
Also there was different changes according to move TestDescription into ctors/common.hpp
yuriykoch
reviewed
Jan 26, 2022
SYCL/ESIMD/api/functional/operators/operator_assignment_move_core.cpp
Outdated
Show resolved
Hide resolved
- Rename ctors into operators - Rename variables - Add assert tu verify that USM was allocated correctly - Add possible to specify init value to shared_element
|
CI on Windows platform failed due to issue, that is not related to this PR (failed Plugin/level_zero_device_scope_events.cpp tests) this test disabled, but fix not merged yet. |
Revert ctors/common.hpp that has deleted in this PR
|
@intel/dpcpp-tools-reviewers @intel/llvm-reviewers-runtime @steffenlarsen |
kbobrovs
reviewed
Feb 2, 2022
SYCL/ESIMD/api/functional/common.hpp
Outdated
| @@ -46,6 +46,9 @@ template <typename T> bool are_bitwise_equal(T lhs, T rhs) { | |||
|
|
|||
| } // namespace details | |||
|
|
|||
| // Dummy kernel for submitting some code into device side. | |||
There was a problem hiding this comment.
Suggested change
| // Dummy kernel for submitting some code into device side. | |
| // Class used as a kernel ID. |
There was a problem hiding this comment.
I've applied this comment here
kbobrovs
reviewed
Feb 2, 2022
kbobrovs
reviewed
Feb 2, 2022
SYCL/ESIMD/api/functional/operators/operator_assignment_move_core.cpp
Outdated
Show resolved
Hide resolved
kbobrovs
reviewed
Feb 2, 2022
kbobrovs
approved these changes
Feb 8, 2022
myler
pushed a commit
to myler/llvm-test-suite
that referenced
this pull request
Apr 12, 2022
…ntel#762) * [SYCL][ESIMD] Add tests on simd copy and move assignment operators
myler
pushed a commit
to myler/llvm-test-suite
that referenced
this pull request
Jun 17, 2022
…ntel#762) * [SYCL][ESIMD] Add tests on simd copy and move assignment operators
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
…ntel/llvm-test-suite#762) * [SYCL][ESIMD] Add tests on simd copy and move assignment operators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.