-
Notifications
You must be signed in to change notification settings - Fork 130
[SYCL] test new complex support by group_algorithms #767
[SYCL] test new complex support by group_algorithms #767
Conversation
… and reduce_over_group Signed-off-by: Chris Perkins <[email protected]>
Signed-off-by: Chris Perkins <[email protected]>
Signed-off-by: Chris Perkins <[email protected]>
Signed-off-by: Chris Perkins <[email protected]>
Signed-off-by: Chris Perkins <[email protected]>
/verify with intel/llvm#5394 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests look good, but I fear it could cause failures on devices without aspect::fp64
. Do we test on any such devices?
@steffenlarsen - I added protection to check for aspect::fp64 before testing std::complex |
You have! But the problem is that the kernel using fp64 operations may be bundled together with the other kernels. This means when the test kernels are built they may include this kernel and fail. |
/verify with intel/llvm#5394 |
Many of the group algorithms already support std::complex data types, but not all. There is a new extension that defines their expanded use in the reduce and scan group algorithms. ( [here](https://github.com/intel/llvm/blob/sycl/sycl/doc/extensions/ComplexAlgorithms/ComplexAlgorithms.asciidoc) ). This PR implements that new extension. Tests have been updated here: intel/llvm-test-suite#767
The potential fixes for the situation may be:
|
I believe this is ready for merge. |
don't we want to add -fsycl-device-code-split=per_kernel to avoid potential failures on devices that do not support fp64? |
Signed-off-by: Chris Perkins <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for adding the split. 😄
Signed-off-by: Chris Perkins <[email protected]>
…suite#767) Signed-off-by: Chris Perkins <[email protected]>
These test updates support intel/llvm#5394 where we expand some of the group algorithms to support std::complex data type.
Signed-off-by: Chris Perkins [email protected]