This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[SYCL][ESIMD] Add test on simd load constructor for fp_extra types #797
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It makes variable name more self describe
|
Looks like 26b43da should be in a separate PR, with |
@yuriykoch yes, you is right, 26b43da has been reverted and these changes will be provided in a separate PR |
|
@sndmitriev Would you mind to take a look? |
sndmitriev
previously approved these changes
Feb 14, 2022
|
@kbobrovs Would you mind to merge this PR? |
vladimirlaz
suggested changes
Feb 14, 2022
@vladimirlaz Done. Let's wait CI result |
|
@sndmitriev I am sorry that I request approval from you third time for this PR. But could you approve this PR? |
sndmitriev
approved these changes
Feb 16, 2022
|
@kbobrovs Would you merge this PR? |
kbobrovs
approved these changes
Feb 18, 2022
|
@vladimirlaz , please approve and merge, I can't due to "1 change requested" |
vladimirlaz
approved these changes
Feb 21, 2022
myler
added a commit
to myler/llvm-test-suite
that referenced
this pull request
Apr 12, 2022
Auto pulldown and update tc files for xmain branch on 20220325
myler
added a commit
to myler/llvm-test-suite
that referenced
this pull request
Apr 12, 2022
myler
added a commit
to myler/llvm-test-suite
that referenced
this pull request
Apr 12, 2022
add '/SYCL/Plugin/*level_zero*' back to fix intel#797 merge issue.
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
…ntel/llvm-test-suite#797) * [SYCL][ESIMD] Add test on simd load constructor for fp_extra types * [SYCL][ESIMD] Replace "dim" with "size" It makes variable name more self describe * Revert "[SYCL][ESIMD] Replace "dim" with "size"" This reverts commit 26b43da97c29a20423e16bf7f25b3922c2fcce59.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend coverage for existing test on simd load constructor by coverage extra floating point types.
There is no changes in the tests logic.