Skip to content
This repository was archived by the owner on Mar 28, 2023. It is now read-only.

[SYCL][ESIMD] Replace "dim", "dimensions" with "size", "sizes", etc. #803

Merged
merged 3 commits into from
Feb 14, 2022

Conversation

vasilytric
Copy link

There is no changes in the tests logic.
There are just changes that are related to replacing "dim" with "size".
Also older get_dimensions and get_all_dimensions are not deleted yet, they saved for the backward compatibility and will be deleted later.

@vasilytric
Copy link
Author

@sndmitriev Would you mind to take a look?

sndmitriev
sndmitriev previously approved these changes Feb 7, 2022
Copy link

@sndmitriev sndmitriev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vasilytric
Copy link
Author

@kbobrovs Sergey have approved this PR would you mind to merge this PR?

@vasilytric
Copy link
Author

@kbobrovs Would you mind to merge this PR?

@vladimirlaz vladimirlaz merged commit e37c075 into intel:intel Feb 14, 2022
myler pushed a commit to myler/llvm-test-suite that referenced this pull request Apr 12, 2022
myler pushed a commit to myler/llvm-test-suite that referenced this pull request Apr 12, 2022
[SYCL] Remove XFAIL in SubGroup load_store test
myler pushed a commit to myler/llvm-test-suite that referenced this pull request Jun 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants