This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[SYCL][FPGA][NFC] Change AOT tool requirement for FPGA emulator #807
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'opencl-aot' is used as backend compiler for FPGA emulator device instead of 'aoc' tool now. Change AOT compilation tool requirement for tests that should be executed on FPGA emulator device. Signed-off-by: Mikhail Lychkov <[email protected]>
|
@alexbatashev Strictly speaking, there are no tests for FPGA hardware target in this suite, because additional command line option should be specified for SYCL compiler to build a binary for that target. |
AlexeySachkov
previously approved these changes
Feb 7, 2022
vladimirlaz
suggested changes
Feb 9, 2022
There was a problem hiding this comment.
can we also remove aoc from https://github.com/intel/llvm-test-suite/blob/intel/SYCL/lit.cfg.py#L399?
Signed-off-by: Mikhail Lychkov <[email protected]>
mlychkov
dismissed stale reviews from AlexeySachkov and alexbatashev
via
24eaeb1
vladimirlaz
approved these changes
Feb 9, 2022
|
@vladimirlaz I updated PR's description. Could you please use it as commit message when you'll be merging this patch? |
AlexeySachkov
approved these changes
Feb 9, 2022
alexbatashev
approved these changes
Feb 9, 2022
myler
pushed a commit
to myler/llvm-test-suite
that referenced
this pull request
Apr 12, 2022
…l#807) 'aoc' tool requires FPGA card and corresponding SDK to compile binaries for FPGA HW target. However, this test suite supports testing on FPGA emulator device only. 'opencl-aot' tool is used as a backend compiler for that target instead of 'aoc'. Remove 'aoc' tool from llvm-test-suite configuration and change AOT compilation tool requirement for tests that should be executed on FPGA emulator device. Signed-off-by: Mikhail Lychkov [email protected]
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
…l/llvm-test-suite#807) 'aoc' tool requires FPGA card and corresponding SDK to compile binaries for FPGA HW target. However, this test suite supports testing on FPGA emulator device only. 'opencl-aot' tool is used as a backend compiler for that target instead of 'aoc'. Remove 'aoc' tool from llvm-test-suite configuration and change AOT compilation tool requirement for tests that should be executed on FPGA emulator device. Signed-off-by: Mikhail Lychkov [email protected]
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'aoc' tool requires FPGA card and corresponding SDK to compile binaries for
FPGA HW target. However, this test suite supports testing on FPGA emulator
device only. 'opencl-aot' tool is used as backend compiler for that target
instead of 'aoc'.
Remove 'aoc' tool from llvm-test-suite configuration and change AOT compilation
tool requirement for tests that should be executed on FPGA emulator device.
Signed-off-by: Mikhail Lychkov [email protected]