This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[SYCL][ESIMD] Add tests on simd increment and decrement operators #827
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuriykoch
reviewed
Feb 11, 2022
SYCL/ESIMD/api/functional/operators/operator_decrement_and_increment.hpp
Outdated
Show resolved
Hide resolved
SYCL/ESIMD/api/functional/operators/operator_decrement_and_increment.hpp
Outdated
Show resolved
Hide resolved
SYCL/ESIMD/api/functional/operators/operator_decrement_and_increment.hpp
Outdated
Show resolved
Hide resolved
SYCL/ESIMD/api/functional/operators/operator_decrement_and_increment.hpp
Outdated
Show resolved
Hide resolved
SYCL/ESIMD/api/functional/operators/operator_decrement_and_increment.hpp
Outdated
Show resolved
Hide resolved
SYCL/ESIMD/api/functional/operators/operator_decrement_and_increment_fp_extra.cpp
Outdated
Show resolved
Hide resolved
SYCL/ESIMD/api/functional/operators/operator_decrement_and_increment.hpp
Outdated
Show resolved
Hide resolved
SYCL/ESIMD/api/functional/operators/operator_decrement_and_increment.hpp
Outdated
Show resolved
Hide resolved
- change verification logic - rename variable
…test It provides use an existed common code without copy pasting
yuriykoch
reviewed
Feb 15, 2022
SYCL/ESIMD/api/functional/operators/operator_decrement_and_increment.hpp
Outdated
Show resolved
Hide resolved
SYCL/ESIMD/api/functional/operators/operator_decrement_and_increment.hpp
Outdated
Show resolved
Hide resolved
SYCL/ESIMD/api/functional/operators/operator_decrement_and_increment.hpp
Outdated
Show resolved
Hide resolved
SYCL/ESIMD/api/functional/operators/operator_decrement_and_increment.hpp
Outdated
Show resolved
Hide resolved
SYCL/ESIMD/api/functional/operators/operator_decrement_and_increment.hpp
Outdated
Show resolved
Hide resolved
SYCL/ESIMD/api/functional/operators/operator_decrement_and_increment.hpp
Outdated
Show resolved
Hide resolved
SYCL/ESIMD/api/functional/operators/operator_decrement_and_increment.hpp
Outdated
Show resolved
Hide resolved
SYCL/ESIMD/api/functional/operators/operator_decrement_and_increment.hpp
Outdated
Show resolved
Hide resolved
SYCL/ESIMD/api/functional/operators/operator_decrement_and_increment_accuracy_core.cpp
Outdated
Show resolved
Hide resolved
- Change log message - Small refactoring - variable renaming
yuriykoch
reviewed
Feb 17, 2022
SYCL/ESIMD/api/functional/operators/operator_decrement_and_increment.hpp
Outdated
Show resolved
Hide resolved
SYCL/ESIMD/api/functional/operators/operator_decrement_and_increment.hpp
Outdated
Show resolved
Hide resolved
SYCL/ESIMD/api/functional/operators/operator_decrement_and_increment.hpp
Outdated
Show resolved
Hide resolved
- Remove unnecessary if else - Remove duplicated for cycle - Fix logic statement in "if" condition - Remove unused aliases
|
@sndmitriev Would you mind to review this PR? |
sndmitriev
previously approved these changes
Feb 22, 2022
SYCL/ESIMD/api/functional/operators/operator_decrement_and_increment_accuracy_core.cpp
Outdated
Show resolved
Hide resolved
SYCL/ESIMD/api/functional/operators/operator_decrement_and_increment_accuracy_fp_extra.cpp
Outdated
Show resolved
Hide resolved
sndmitriev
approved these changes
Feb 24, 2022
|
@kbobrovs Would you mind to merge this PR? |
myler
pushed a commit
to myler/llvm-test-suite
that referenced
this pull request
Apr 12, 2022
…tel#827) * [SYCL][ESIMD] Add tests on simd increment and decrement operators
myler
pushed a commit
to myler/llvm-test-suite
that referenced
this pull request
Jun 17, 2022
…tel#827) * [SYCL][ESIMD] Add tests on simd increment and decrement operators
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
…tel/llvm-test-suite#827) * [SYCL][ESIMD] Add tests on simd increment and decrement operators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.