This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[SYCL][ESIMD] Add verifications that device has necessary aspects #839
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, Vasily |
yuriykoch
reviewed
Feb 14, 2022
- Rename should_run_test_with_current_datatype with should_skip_test_with - Add comment to should_skip_test_with function - Change should_skip_test_with function signature: obtain reference to device instead of rvalue device
|
@kbobrovs Would you mind to take a look? |
v-klochkov
previously approved these changes
Feb 22, 2022
v-klochkov
reviewed
Feb 22, 2022
|
@v-klochkov all comments has been applied, would you mind to merge this PR? |
v-klochkov
approved these changes
Feb 24, 2022
myler
pushed a commit
to myler/llvm-test-suite
that referenced
this pull request
Apr 12, 2022
* [SYCL][ESIMD] Add verifications that device has necessary aspects
myler
pushed a commit
to myler/llvm-test-suite
that referenced
this pull request
Jun 17, 2022
* [SYCL][ESIMD] Add verifications that device has necessary aspects
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
…m-test-suite#839) * [SYCL][ESIMD] Add verifications that device has necessary aspects
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide verifications that device has necessary aspects to interact with
doubleorsycl::halfdata types, if device doesn't has necessary aspects such data type will be skipped during runtime