Skip to content
This repository was archived by the owner on Mar 28, 2023. It is now read-only.

[SYCL][L0] check copy operations on interop queue #855

Merged
merged 1 commit into from
Nov 2, 2022

Conversation

smaslov-intel
Copy link

Signed-off-by: Sergey V Maslov [email protected]

@smaslov-intel smaslov-intel requested a review from a team as a code owner February 18, 2022 15:57

// Copy submissions crashes with discrete GPUs.
int hostMem;
// int *hostMem = (int*)malloc_host(sizeof(int), Q2);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am sorry, I somehow missed this PR.

I am trying to understand what we are trying to check here. Is it expected to fail if hostMem is allocated using malloc_host?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is only trying to check that "memcpy" at line 27 works OK with interop-queue. I don't recall why "malloc_host" was causing problems. Will try again.

@smaslov-intel smaslov-intel requested a review from a team as a code owner November 1, 2022 15:52
@againull
Copy link

againull commented Nov 1, 2022

@smaslov-intel Could you please fix clang-format issue.

@smaslov-intel
Copy link
Author

/verify with intel/llvm#7253

@smaslov-intel
Copy link
Author

/verify with intel/llvm#7253

@againull : the test revealed some problem that I am fixing in the compiler

@smaslov-intel
Copy link
Author

/verify with intel/llvm#7253

@smaslov-intel
Copy link
Author

/verify with intel/llvm#7253

@smaslov-intel
Copy link
Author

The added test passed with intel/llvm#7253
The reported failure cannot be realted:

[2022-11-02T19:15:56.297Z] Failed Tests (1):
[2022-11-02T19:15:56.297Z] SYCL :: KernelAndProgram/kernel-bundle-merge-options-env.cpp

Please consider merging this

@againull againull merged commit c9efc13 into intel:intel Nov 2, 2022
myler pushed a commit to myler/llvm-test-suite that referenced this pull request Mar 22, 2023
aelovikov-intel pushed a commit to aelovikov-intel/llvm that referenced this pull request Mar 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants