Skip to content
This repository was archived by the owner on Mar 28, 2023. It is now read-only.

[SYCL][ESIMD][EMU] ESIMD test updates for esimd_emulator backend #869

Merged
merged 12 commits into from
Mar 7, 2022

Conversation

dongkyunahn-intel
Copy link

  • Reducing number of iterations / Limiting matrix size in order to avoid timeout failure
  • Removing 'XFAIL' from passing tests

- Reducing number of iterations / Limiting matrix size in order to
avoid timeout failure
- Required memory intrinsic implementations are supported in
intel/llvm/sycl
…cript_operator.cpp

- esimd_merge.cpp - XFAIL for explicit failure

- preemption.cpp - UNSUPPORTED as the test consists of empty kernel
and looks for 'preemption' compilation switch from IGC dump which is
not generated under esimd_emulator

- simd_subscript_operator.cpp - test passes as there is no arithmetic
operation for 'half' type while memory intrinsic is fully supported
kbobrovs
kbobrovs previously approved these changes Mar 3, 2022
Copy link

@kbobrovs kbobrovs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Good to see so many new tests will run on emulator!

kychendev
kychendev previously approved these changes Mar 3, 2022
@dongkyunahn-intel
Copy link
Author

@vladimirlaz , would you merge this PR? It is required for enabling ESIMD_EMULATOR in intel/llvm.

intel/llvm#5677

- 'single_task()' support is not yet merged into origin/sycl in intel/llvm
@dongkyunahn-intel
Copy link
Author

@vladimirlaz , I found out one test needs to be updated. I'll let you know when this PR is ready for PR. Sorry for confusion.

@dongkyunahn-intel dongkyunahn-intel dismissed stale reviews from kychendev and kbobrovs via 73157e4 March 7, 2022 06:13
@dongkyunahn-intel
Copy link
Author

@kbobrovs , @kychendev , would you re-approve this PR? One test (variable_gather_mask.cpp) needs to be marked XFAIL for esimd_emulator backend as the feature support is still under review.

@kbobrovs kbobrovs merged commit 7f0ae77 into intel:intel Mar 7, 2022
myler pushed a commit to myler/llvm-test-suite that referenced this pull request Apr 12, 2022
…el#869)

* [SYCL][ESIMD][EMU] ESIMD test updates for esimd_emulator backend

- Reducing number of iterations / Limiting matrix size in order to
avoid timeout failure
- Removing 'XFAIL' from passing tests
- Required memory intrinsic implementations are supported in
intel/llvm/sycl
- Recovering XFAIL for 'SYCL/ESIMD/api/simd_subscript_operator.cpp'
  For unimplemented 'half' type
myler pushed a commit to myler/llvm-test-suite that referenced this pull request Jun 17, 2022
…el#869)

* [SYCL][ESIMD][EMU] ESIMD test updates for esimd_emulator backend

- Reducing number of iterations / Limiting matrix size in order to
avoid timeout failure
- Removing 'XFAIL' from passing tests
- Required memory intrinsic implementations are supported in
intel/llvm/sycl
- Recovering XFAIL for 'SYCL/ESIMD/api/simd_subscript_operator.cpp'
  For unimplemented 'half' type
aelovikov-intel pushed a commit to aelovikov-intel/llvm that referenced this pull request Mar 27, 2023
…el/llvm-test-suite#869)

* [SYCL][ESIMD][EMU] ESIMD test updates for esimd_emulator backend

- Reducing number of iterations / Limiting matrix size in order to
avoid timeout failure
- Removing 'XFAIL' from passing tests
- Required memory intrinsic implementations are supported in
intel/llvm/sycl
- Recovering XFAIL for 'SYCL/ESIMD/api/simd_subscript_operator.cpp'
  For unimplemented 'half' type
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants