This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[SYCL] Add test for reductions using the resource pool #873
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current implementation of SYCL reductions may require some additional device-memory resources. To reduce the overhead of allocating memory every time a reduction runs, a resource pool is employed. These changes add a test to ensure that the resource pool prevents repeated allocations for reductions needing these resources. Signed-off-by: Steffen Larsen <[email protected]>
Signed-off-by: Steffen Larsen <[email protected]>
|
/verify with intel/llvm#5662 |
vladimirlaz
approved these changes
Feb 28, 2022
vladimirlaz
suggested changes
Feb 28, 2022
| @@ -0,0 +1,35 @@ | |||
| // RUN: %clangxx -fsycl -fsycl-targets=%sycl_triple %s -o %t.out -Xsycl-target-backend=nvptx64-nvidia-cuda --cuda-gpu-arch=sm_60 | |||
There was a problem hiding this comment.
the test is built for CUDA BE
Is it expected?
Suggested change
| // RUN: %clangxx -fsycl -fsycl-targets=%sycl_triple %s -o %t.out -Xsycl-target-backend=nvptx64-nvidia-cuda --cuda-gpu-arch=sm_60 | |
| // RUN: %clangxx -fsycl -fsycl-targets=%sycl_triple %s -o %t.out |
There was a problem hiding this comment.
These options only have an effect if the sycl target is the CUDA backend and are ignored otherwise. All it does is instruct the generation of NVPTX to use SM60, which I believe is required here to enable an extended set of atomic operations used by reductions.
myler
pushed a commit
to myler/llvm-test-suite
that referenced
this pull request
Jun 17, 2022
Fix CMPLRTST-16222: disable hier_par_wgscope_O0 on discrete GPUs because of a hang issue
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of SYCL reductions may require some additional device-memory resources. To reduce the overhead of allocating memory every time a reduction runs, a resource pool is employed. These changes add a test to ensure that the resource pool prevents repeated allocations for reductions needing these resources.