This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[SYCL][ESIMD] Add tests on simd select 1D functions #875
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuriykoch
reviewed
Mar 9, 2022
SYCL/ESIMD/api/functional/functions/functions_select_rvalue.hpp
Outdated
Show resolved
Hide resolved
SYCL/ESIMD/api/functional/functions/functions_select_rvalue.hpp
Outdated
Show resolved
Hide resolved
SYCL/ESIMD/api/functional/functions/functions_select_rvalue.hpp
Outdated
Show resolved
Hide resolved
SYCL/ESIMD/api/functional/functions/functions_select_rvalue.hpp
Outdated
Show resolved
Hide resolved
SYCL/ESIMD/api/functional/functions/functions_select_rvalue.hpp
Outdated
Show resolved
Hide resolved
SYCL/ESIMD/api/functional/functions/functions_select_rvalue.hpp
Outdated
Show resolved
Hide resolved
SYCL/ESIMD/api/functional/functions/functions_select_rvalue.hpp
Outdated
Show resolved
Hide resolved
SYCL/ESIMD/api/functional/functions/functions_select_rvalue.hpp
Outdated
Show resolved
Hide resolved
- Add constexpr ceil function - Rename function - Use different algorithm to verify obtained result
yuriykoch
reviewed
Mar 11, 2022
Now it works with two int args to avoid UB float value may be greater than int values range
- Update comments - Rename variables - Rename files
yuriykoch
reviewed
Mar 14, 2022
This lets do not mention all arguments explicitly
|
@sndmitriev Would you mind to review this PR? |
sndmitriev
approved these changes
Mar 18, 2022
|
@kbobrovs Would you mind to merge this PR? |
myler
pushed a commit
to myler/llvm-test-suite
that referenced
this pull request
Jun 17, 2022
Provides tests for select r-value, l-value and for 1D simd_view functions.
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
…suite#875) Provides tests for select r-value, l-value and for 1D simd_view functions.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides tests for select r-value, l-value and for 1D simd_view functions.