Skip to content
This repository was archived by the owner on Mar 28, 2023. It is now read-only.

[SYCL] Speed up atomic_ref tests #879

Merged
merged 3 commits into from
Mar 10, 2022

Conversation

vladimirlaz
Copy link

@vladimirlaz vladimirlaz commented Mar 2, 2022

The full test coverage of sycl::atomic_ref functionality is reached in SYCL-CTS tests. Limiting tests to speed up test execution (600+ seconds to 30- seconds):

  • single build per test is done having all test cases;
  • limiting type coverage to float to use native float atomics (to caver native fp atomics if available) and int (for and, or, xor operation which does not support floating point operation);
  • guard deprecated API (::sycl::ext::oneapi::atomic_ref) with RUN_DEPRECATED and removed from default execution;
  • guard full type coverage with FULL_ATOMIC32_COVERAGE and FULL_ATOMIC64_COVERAGE macros;
  • fixed atomic_memory_scope_capabilities checks.

@vladimirlaz vladimirlaz requested a review from a team as a code owner March 2, 2022 12:03
sergey-semenov
sergey-semenov previously approved these changes Mar 2, 2022
@bader bader requested a review from yanfeng3721 March 2, 2022 13:23
@vladimirlaz vladimirlaz marked this pull request as draft March 5, 2022 07:55
@vladimirlaz vladimirlaz changed the title [SYCL] Fix XFAIL rules [SYCL] Speed up atomic_ref tests Mar 5, 2022
@vladimirlaz vladimirlaz requested a review from t4c1 March 5, 2022 18:08
@vladimirlaz vladimirlaz marked this pull request as ready for review March 5, 2022 18:22
Copy link

@t4c1 t4c1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is reducing the test coverage to a single type per operation necessary to reach the required testing time? If it is, it might make sense to put tests for other types behind a macro like you did with deprecated tests from ext namespace.

@vladimirlaz vladimirlaz requested a review from t4c1 March 7, 2022 20:03
Copy link

@t4c1 t4c1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vladimirlaz
Copy link
Author

@sergey-semenov could you please have a look/approve?

@vladimirlaz
Copy link
Author

@yanfeng3721 could you please have a look?

@yanfeng3721
Copy link

@yanfeng3721 could you please have a look?

LGTM.

@vladimirlaz vladimirlaz merged commit a5f90c0 into intel:intel Mar 10, 2022
myler pushed a commit to myler/llvm-test-suite that referenced this pull request Apr 12, 2022
myler pushed a commit to myler/llvm-test-suite that referenced this pull request Jun 17, 2022
aelovikov-intel pushed a commit to aelovikov-intel/llvm that referenced this pull request Mar 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants