This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[SYCL][CUDA] Enable sub-group load_store tests #90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test assumed that it was safe to load/store off the end of a buffer as long as the results of those accesses were ignored. Some backends (e.g. CUDA) will fail because of an out-of-bounds access, so it's safer to pad the buffers instead. Signed-off-by: John Pennycook <[email protected]>
Signed-off-by: John Pennycook <[email protected]>
Using // caused comments to run together. Using #if 0 allows them to remain formatted like real lines. Signed-off-by: John Pennycook <[email protected]>
|
@Pennycook could you please remove tests in intel/llvm#2763 to resolve conflicts. |
Oh, woops. I'd done that locally but forgot to push. Should be fixed now. |
vladimirlaz
approved these changes
Jan 13, 2021
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
) * Prevent out-of-bounds access in load_store. The test assumed that it was safe to load/store off the end of a buffer as long as the results of those accesses were ignored. Some backends (e.g. CUDA) will fail because of an out-of-bounds access, so it's safer to pad the buffers instead. * Enable sub-group load_store tests Signed-off-by: John Pennycook <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests associated with new functionality from intel/llvm#2763.