Skip to content
This repository was archived by the owner on Mar 28, 2023. It is now read-only.

[SYCL][CUDA] Enable tests for generic atomics #929

Closed
wants to merge 5 commits into from

Conversation

t4c1
Copy link

@t4c1 t4c1 commented Mar 21, 2022

Enables tests for generic atomics for CUDA backend.

Tests intel/llvm#5849.

Closes intel/llvm#8807.

@denis-kabanov
Copy link

@t4c1, I think these XFAILs should not be removed due to comment, can you sync commit with syclos?

@steffenlarsen
Copy link

@t4c1 - Could you please push a rebase or a merge commit so retrigger testing?

@t4c1
Copy link
Author

t4c1 commented May 26, 2022

I would not expect this to be merged anyway, as the PR this is testing hit on some remangler issues on Windows. The last set of tests only passed because tests were somehow not run on Windows.

@steffenlarsen
Copy link

I would not expect this to be merged anyway, as the PR this is testing hit on some remangler issues on Windows. The last set of tests only passed because tests were somehow not run on Windows.

In that case, should this be moved to draft?

@t4c1 t4c1 marked this pull request as draft May 26, 2022 09:49
steffenlarsen pushed a commit that referenced this pull request Dec 14, 2022
@jchlanda
Copy link

This can be closed now that #1446 is in, right @t4c1 ?

@t4c1
Copy link
Author

t4c1 commented Dec 14, 2022

Yes, I think so.

@t4c1 t4c1 closed this Dec 14, 2022
aelovikov-intel pushed a commit to aelovikov-intel/llvm that referenced this pull request Mar 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CUDA] Enable tests in AtomicRef for CUDA after adding support for generic address space in DPC++
4 participants