Skip to content
This repository was archived by the owner on Mar 28, 2023. It is now read-only.

[SYCL] Enable undefined-symbol test for the opencl and gpu #944

Open
wants to merge 1 commit into
base: intel
Choose a base branch
from
Open

[SYCL] Enable undefined-symbol test for the opencl and gpu #944

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion SYCL/KernelAndProgram/undefined-symbol.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// XFAIL: cuda || hip || (opencl && gpu)
// XFAIL: cuda || hip
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you clarify why this test still fails in Jenkins environment?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to me, that test become pass only on OCL GEN9 Linux test suite. If it is related to the intel/llvm#5867, then test will fail on windows, drivers were updated only for linux.
May be, we can specialize test suites on which this test should pass? I don't know how to do it.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test fails on Linux as well. I suggest we investigate the difference between test behavior in Jenkins and GitHub Actions environments.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but I don't understand which test suite is used on jenkins for linux.
Yes, we should investigate. I'll try to figure out.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understand correctly, drivers in Github Actions docker container for OCL GEN9 more recent, than in the jenkins.
OCL GEN9 Github Actions have version 22.11.22682, that matches version from the uplift PR for 'linux_staging'. Can be seen in raw logs from here

Jenkins have version 22.10.22597.

Anyway, we can't enable test only for specific driver version. Should we disable it for now, while it fails on some driver versions?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You seem to be right. I think we must align driver version for both systems before merging any patches.
@alexbatashev, could you clarify why GHA is using more recent version than buildbot for pre-commit? I assumed it should be used only for nightly jobs.
There is a PR uplifting Jenkins version to 22.11.*, but I see new failures in pre-commit for this change. intel/llvm#5897
Probably the safer way is to rollback the driver version for GHA and commit intel/llvm#5897 together with this patch once all pre-commit issues are addressed.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reverted driver version in GHA precommit to 22.10.*.
This patch should go together with intel/llvm#5897.

// RUN: %clangxx -fsycl %s -o %t.out
// RUN: %CPU_RUN_PLACEHOLDER %t.out
// RUN: %GPU_RUN_PLACEHOLDER %t.out
Expand Down