This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[SYCL][CUDA] Add tests for exceeding maximum number of work groups #952
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexbatashev
previously approved these changes
Mar 28, 2022
alexbatashev
previously approved these changes
Mar 28, 2022
steffenlarsen
approved these changes
Mar 28, 2022
alexbatashev
approved these changes
Apr 1, 2022
steffenlarsen
pushed a commit
to intel/llvm
that referenced
this pull request
Apr 8, 2022
) Improves the error message when the user specifies a number of work groups in certain dimension, which exceeds CUDA's max grid dimension limits. Before this PR the error message is not very informative: ``` PI CUDA ERROR: Value: 1 Name: CUDA_ERROR_INVALID_VALUE Description: invalid argument Function: cuda_piEnqueueKernelLaunch Source Location: /home/tadej/llvm/sycl/plugins/cuda/pi_cuda.cpp:2662 terminate called after throwing an instance of 'cl::sycl::runtime_error' what(): Native API failed. Native API returns: -30 (CL_INVALID_VALUE) -30 (CL_INVALID_VALUE) This is especially confusing when porting code from CUDA, due to the fact that dimensions in SYCL are flipped compared to CUDA and CUDA has different limits for different dimensions. ``` Tested by: intel/llvm-test-suite#952
|
@steffenlarsen this can now be merged as well. |
myler
pushed a commit
to myler/llvm-test-suite
that referenced
this pull request
Jun 17, 2022
…ntel#952) Add tests for checking the error for exceeding maximum number of work groups. Tests changes in intel/llvm#4563.
myler
pushed a commit
to myler/llvm-test-suite
that referenced
this pull request
Jun 17, 2022
…topic Fix CMPLRTST-16712: Skip some image LIT tests on PVC because images are not supported by this device.
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
…ntel/llvm-test-suite#952) Add tests for checking the error for exceeding maximum number of work groups. Tests changes in intel#4563.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests for checking the error for exceeding maximum number of work groups.
Tests changes in intel/llvm#4563.