This repository was archived by the owner on Mar 28, 2023. It is now read-only.
Fix batching test for PR 5977 #978
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arvind Sudarsanam <[email protected]>
|
/verify with intel/llvm#5977 |
againull
reviewed
Apr 7, 2022
| @@ -166,7 +166,7 @@ int main(int argc, char *argv[]) { | |||
| validate(Y1, Z7, M * N); | |||
| validate(Y1, Z8, M * N); | |||
|
|
|||
| for (size_t i = 0; i < 20; i++) { | |||
| for (size_t i = 0; i < 25; i++) { | |||
There was a problem hiding this comment.
Could you please clarify why this change is needed. Does test fail when 20 iterations? Or do you want to test some specific behaviour with 25 iterations?
There was a problem hiding this comment.
Oh, I see from the comment to intel/llvm PR that test is failing when 20 iterations. Is it clear why it fails and is it expected to fail with 20 iterations?
There was a problem hiding this comment.
In PR 5977, we are changing the thresholds that control how batching is done. This change is expected to give some performance improvements. It does change the way the batch size is lowered/raised and that's what we test here. So, a change is needed here. Thanks.
againull
approved these changes
Apr 12, 2022
myler
pushed a commit
to myler/llvm-test-suite
that referenced
this pull request
Jun 17, 2022
Signed-off-by: Arvind Sudarsanam <[email protected]>
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
Signed-off-by: Arvind Sudarsanam <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Arvind Sudarsanam [email protected]